Bug 30660 - Add cancellation reason to holds delete endpoint
Summary: Add cancellation reason to holds delete endpoint
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Johanna Räisä
QA Contact: Pedro Amorim
URL:
Keywords:
Depends on:
Blocks: 23269
  Show dependency treegraph
 
Reported: 2022-05-02 07:14 UTC by Johanna Räisä
Modified: 2024-11-21 20:35 UTC (History)
7 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement adds the ability to send a hold cancellation reason to the delete hold API endpoint.
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 30660: Add cancellation reason to holds delete endpoint (2.07 KB, patch)
2022-08-29 10:16 UTC, Johanna Räisä
Details | Diff | Splinter Review
Bug 30660: Add cancellation reason to holds delete endpoint (2.03 KB, patch)
2024-08-21 10:48 UTC, Johanna Räisä
Details | Diff | Splinter Review
Bug 30660: Add cancellation reason to holds delete endpoint (2.07 KB, patch)
2024-08-21 11:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 30660: Add cancellation reason to holds delete endpoint (2.15 KB, patch)
2024-10-22 14:15 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Johanna Räisä 2022-05-02 07:14:02 UTC
The holds delete endpoint is missing cancellation reason. Should be able to add it also via REST API.
Comment 1 Johanna Räisä 2022-08-29 10:16:09 UTC
Created attachment 139941 [details] [review]
Bug 30660: Add cancellation reason to holds delete endpoint

This patch adds cancellation reason to holds delete endpoint.

Test plan:
1) prove t/db_dependent/api/v1/holds.t

Sponsored-by: Koha-Suomi Oy
Comment 2 David Nind 2022-09-12 20:36:33 UTC
The tests fail after applying the patch. There was quite a lot of output, so I'm just posting the last bit:

...
Can't use an undefined value as a HASH reference at t/db_dependent/api/v1/holds.t line 252.
# Looks like your test exited with 11 just after 3.
t/db_dependent/api/v1/holds.t .. Dubious, test returned 11 (wstat 2816, 0xb00)
Failed 14/14 subtests 

Test Summary Report
-------------------
t/db_dependent/api/v1/holds.t (Wstat: 2816 Tests: 3 Failed: 3)
  Failed tests:  1-3
  Non-zero exit status: 11
  Parse errors: Bad plan.  You planned 14 tests but ran 3.
Files=1, Tests=3,  4 wallclock secs ( 0.01 usr  0.01 sys +  3.48 cusr  0.22 csys =  3.72 CPU)
Result: FAIL
Comment 3 Johanna Räisä 2024-08-21 10:48:16 UTC
Created attachment 170557 [details] [review]
Bug 30660: Add cancellation reason to holds delete endpoint

This patch adds cancellation reason to holds delete endpoint.

Test plan:
1) prove t/db_dependent/api/v1/holds.t

Sponsored-by: Koha-Suomi Oy
Comment 4 David Nind 2024-08-21 11:22:27 UTC
Created attachment 170559 [details] [review]
Bug 30660: Add cancellation reason to holds delete endpoint

This patch adds cancellation reason to holds delete endpoint.

Test plan:
1) prove t/db_dependent/api/v1/holds.t

Sponsored-by: Koha-Suomi Oy
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Pedro Amorim 2024-10-22 14:15:22 UTC
Created attachment 173158 [details] [review]
Bug 30660: Add cancellation reason to holds delete endpoint

This patch adds cancellation reason to holds delete endpoint.

Test plan:
1) prove t/db_dependent/api/v1/holds.t

PA amended: tidy

Sponsored-by: Koha-Suomi Oy
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 6 Katrin Fischer 2024-10-25 09:12:25 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 Lucas Gass (lukeg) 2024-11-18 23:07:32 UTC
Enhancement, no 24.05.x backport