Description
Katrin Fischer
2022-06-18 10:39:20 UTC
Created attachment 137664 [details] [review] Bug 30992: Improve translatability for Waiting at|On hold Created attachment 137665 [details] [review] Bug 30992: Improve translatability for 'for' Created attachment 137666 [details] [review] Bug 30992: Improve translatability for Waiting at|On hold Created attachment 137667 [details] [review] Bug 30992: Improve translatability for 'for' I think those patches are working as you expect. Can this be updated from New to Needs Signoff? :) (In reply to Katrin Fischer from comment #6) > Can this be updated from New to Needs Signoff? :) I haven't tested them, but feel free to do so. The second patch doesn't quite work: - <span>for</span> - [% IF ( subscription_LOO.numberlength ) %][% subscription_LOO.numberlength | html %] <span>issues</span>[% END %] - [% IF ( subscription_LOO.weeklength ) %][% subscription_LOO.weeklength | html %] <span>weeks</span>[% END %] - [% IF ( subscription_LOO.monthlength ) %][% subscription_LOO.monthlength | html %] <span>months</span>[% END %] + [% IF ( subscription_LOO.numberlength ) %][% subscription_LOO.numberlength | html %] <span>for issues</span>[% END %] Before: for x months Now: 4 for months Created attachment 137855 [details] [review] Bug 30992: Improve translatability for 'for' Created attachment 138393 [details] [review] Bug 30992: Improve translatability for Waiting at|On hold Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 138394 [details] [review] Bug 30992: Improve translatability for 'for' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 138661 [details] [review] Bug 30992: Improve translatability for Waiting at|On hold Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 138662 [details] [review] Bug 30992: Improve translatability for 'for' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> A clear improvement, no regressions. Passing QA Pushed to master for 22.11. Nice work everyone, thanks! There is a typo here https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138661&action=diff#a/opac/opac-reserve.pl_sec1 $itemLoopIter->{reservedate} = $first_hold->reservedate, $itemLoopIter->{ExpectedAtLibrary} = $first_hold->branchcode; 1st line ends with a comma instead of a semicolon. Shouldn't this not compile and have blown up during testing? And even the CI should blow up when checking syntax validity. Strange, it didn't explode when I tested or wrote my follow-up. Created attachment 138764 [details] [review] Bug 30992: (follow-up) Fix semicolon at line ending $itemLoopIter->{reservedate} = $first_hold->reservedate, $itemLoopIter->{ExpectedAtLibrary} = $first_hold->branchcode; 1st line ends with a comma instead of a semicolon. (In reply to Victor Grousset/tuxayo from comment #16) > Shouldn't this not compile and have blown up during testing? > And even the CI should blow up when checking syntax validity. It's syntaxically valid. Follow-up pushed to master. Backported to 22.05.x for 22.05.06 quite a lot of conflicts while trying to apply on 21.11.x... If this is really needed I wouldn't refuse some help on the backport (provide backport patch?) |