When placing an item level hold in the OPAC and there are other pending holds, the branchcode will show instead of the branchname: On hold for patron expected at FFL since 07/30/2022 .
Created attachment 138399 [details] [review] Bug 31272: Use TT plugins for pickup library and due date in opac-reserve.pl Before this patch the date formatting for the due date was done in the .pl instead of the template and the branchcode would show instead of the library's name in the list of items when placing an item level hold in the OPAC. To test: * Find or create a record with mulitple items * Check out one of the items * Place a record level hold * Return an item to set to waiting * Place an item level hold * Go to the OPAC and start placing an item level hold * Verify the messages in the item table show the branchcode * Apply patch * Only visible change should be the library name replacing the branchcode
Created attachment 138680 [details] [review] Bug 31272: Use TT plugins for pickup library and due date in opac-reserve.pl Before this patch the date formatting for the due date was done in the .pl instead of the template and the branchcode would show instead of the library's name in the list of items when placing an item level hold in the OPAC. To test: * Find or create a record with mulitple items * Check out one of the items * Place a record level hold * Return an item to set to waiting * Place an item level hold * Go to the OPAC and start placing an item level hold * Verify the messages in the item table show the branchcode * Apply patch * Only visible change should be the library name replacing the branchcode Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice one Katrin, this is a great little improvement. Going straight for QA on this, it's clear and simple and achieves exactly what's on the tin. Passing QA
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.06
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved.
Thanks! Pushed to 21.11 for 21.11.12
(In reply to Arthur Suzuki from comment #7) > Thanks! > > Pushed to 21.11 for 21.11.12 This depends on 30992 which was not backported to 21.11 This means that: reservedate is being formatted in opac-reserve.pl: $itemLoopIter->{reservedate} = output_pref({ dt => dt_from_string($first_hold->reservedate), dateonly => 1 }); # FIXME Should be formatted in the template And is also being formatted in the template: <span>On hold for patron expected at [% Branches.GetName( itemLoo.ExpectedAtLibrary ) | html %] since [% itemLoo.reservedate | $KohaDates %]</span> And DateUtils dies on an unexpected date (as it has already been formatted) Please revert