| Summary: | "Edit search" always resets search options to keyword | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Staff interface | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | bwsdonna, gmcharlt, jonathan.druart, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: |
22.11.00
|
Circulation function: | |
| Bug Depends on: | 22605 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 31271: Preselect previous search index
Bug 31271: Preselect previous search index Bug 31271: Preselect previous search index |
||
|
Description
Katrin Fischer
2022-07-30 15:24:09 UTC
Is it a regression? (In reply to Jonathan Druart from comment #1) > Is it a regression? Hum, guess no. I would argue it is a regression - in previous versions, when I click back to the advanced search to edit the search, the search options are retained. The edit search button should do the same thing. I can click the back arrow and the fields are retained, so having the behavior differ between using the "proper" edit link vs back arrow is rather frustrating. I also felt like I had tested this when the edit link was added... Adding Nick. Created attachment 143086 [details] [review] Bug 31271: Preselect previous search index This patch passes the constructed value of the preselect to search_indexes.inc To test: 1 - Perform an advanced search, making sure to select different indexes 2 - Click 'Edit search' on results page 3 - Confirm index selections are preselected 4 - Enable IntranetCatalogSearchPulldown 5 - Do a search form the top bar using an index 6 - Confirm 'Edit search' correctly popluates the chosen index Created attachment 143139 [details] [review] Bug 31271: Preselect previous search index This patch passes the constructed value of the preselect to search_indexes.inc To test: 1 - Perform an advanced search, making sure to select different indexes 2 - Click 'Edit search' on results page 3 - Confirm index selections are preselected 4 - Enable IntranetCatalogSearchPulldown 5 - Do a search form the top bar using an index 6 - Confirm 'Edit search' correctly popluates the chosen index Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 143496 [details] [review] Bug 31271: Preselect previous search index This patch passes the constructed value of the preselect to search_indexes.inc To test: 1 - Perform an advanced search, making sure to select different indexes 2 - Click 'Edit search' on results page 3 - Confirm index selections are preselected 4 - Enable IntranetCatalogSearchPulldown 5 - Do a search form the top bar using an index 6 - Confirm 'Edit search' correctly popluates the chosen index Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! |