Once we did an advanced search in the OPAC, we have have the option to modify the criterias of this last search ("Return to the last advanced search" just on top of the results list). But in the "on site" Koha we don't have this option. Wchich can save a lot of time when we have long and precise searches to do allowing to refine the criterias rather than enter all of them again. Thanks, Alexandre
By "on site" I mean staff interface. Thanks, Alexandre
Created attachment 114728 [details] [review] Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Library limits can be applied multiple times either as 'AND' option, or using groups for 'OR' 2 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 3 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives
I'm running into problems: - apply patch - restart all - go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl - search title: Street, get results (http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=ti&q=street&idx=kw&q=&idx=kw&q=&sort_by=relevance) - click Edit Search - go to page where my title is not shown in the search form but does appear in the url? (http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=ti&q=street&idx=kw&q=&idx=kw&q=&sort_by=relevance)
Additionally, the more I think about this the more I dislike adding this new wrinkle of and/or multi-branch searching as sort of an afterthought to this feature. I'd be happier to see that split into a separate bug, in hopes of it getting more eyes and feedback.
Created attachment 114734 [details] [review] Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Library limits can be applied multiple times either as 'AND' option, or using groups for 'OR' 2 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 3 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives
Created attachment 114736 [details] [review] Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Library limits can be applied multiple times either as 'AND' option, or using groups for 'OR' 2 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 3 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
We've implemented an "edit search" feature for years locally. It'll be interesting to see what this one is like...
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22605: Add ability to edit a search on staff interface .git/rebase-apply/patch:441: trailing whitespace. warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Search.pm M Koha/SearchEngine/Elasticsearch/QueryBuilder.pm M catalogue/search.pl M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt .git/rebase-apply/patch:441: trailing whitespace. warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging catalogue/search.pl Auto-merging Koha/SearchEngine/Elasticsearch/QueryBuilder.pm CONFLICT (content): Merge conflict in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm Auto-merging C4/Search.pm
Created attachment 117174 [details] [review] Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Library limits can be applied multiple times either as 'AND' option, or using groups for 'OR' 2 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 3 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>