To test: - Go to the advanced search in the staff interface - Select Barcode as search option and search for a non-existing barcode - From the search results, go back by Edit search link - Verify the search option flipped back to Keyword :(
Is it a regression?
(In reply to Jonathan Druart from comment #1) > Is it a regression? Hum, guess no.
I would argue it is a regression - in previous versions, when I click back to the advanced search to edit the search, the search options are retained. The edit search button should do the same thing. I can click the back arrow and the fields are retained, so having the behavior differ between using the "proper" edit link vs back arrow is rather frustrating.
I also felt like I had tested this when the edit link was added... Adding Nick.
Created attachment 143086 [details] [review] Bug 31271: Preselect previous search index This patch passes the constructed value of the preselect to search_indexes.inc To test: 1 - Perform an advanced search, making sure to select different indexes 2 - Click 'Edit search' on results page 3 - Confirm index selections are preselected 4 - Enable IntranetCatalogSearchPulldown 5 - Do a search form the top bar using an index 6 - Confirm 'Edit search' correctly popluates the chosen index
Created attachment 143139 [details] [review] Bug 31271: Preselect previous search index This patch passes the constructed value of the preselect to search_indexes.inc To test: 1 - Perform an advanced search, making sure to select different indexes 2 - Click 'Edit search' on results page 3 - Confirm index selections are preselected 4 - Enable IntranetCatalogSearchPulldown 5 - Do a search form the top bar using an index 6 - Confirm 'Edit search' correctly popluates the chosen index Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 143496 [details] [review] Bug 31271: Preselect previous search index This patch passes the constructed value of the preselect to search_indexes.inc To test: 1 - Perform an advanced search, making sure to select different indexes 2 - Click 'Edit search' on results page 3 - Confirm index selections are preselected 4 - Enable IntranetCatalogSearchPulldown 5 - Do a search form the top bar using an index 6 - Confirm 'Edit search' correctly popluates the chosen index Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!