Bug 31714

Summary: Add a more generic way to print patron slips
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: NoticesAssignee: Martin Renvoize <martin.renvoize>
Status: RESOLVED FIXED QA Contact: Kyle M Hall <kyle>
Severity: enhancement    
Priority: P5 - low CC: david, gmcharlt, kyle, lucas
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
This is a first step towards drying out our slip printing code. We add a new, modern, controller script that accepts any notice template to be passed to it for printing. Next steps would be to start migrating some of the old slips to use this controller and drop their respective controller scripts.
Version(s) released in:
22.11.00
Bug Depends on:    
Bug Blocks: 32344, 32345, 32346, 31713    
Attachments: Bug 31714: Add Generic way to print patron slips
Bug 31714: Add Generic way to print patron slips
Bug 31714: Add Generic way to print patron slips
Bug 31714: Add Generic way to print patron slips

Description Martin Renvoize 2022-10-07 15:28:35 UTC
Our slip printing code is somewhat spread out and custom per notice when in reality we could just have a simple controller passed a letter code and borrowernumber for many cases and then use TT notice templates to get all other details.
Comment 1 Martin Renvoize 2022-10-07 15:31:57 UTC
Created attachment 141515 [details] [review]
Bug 31714: Add Generic way to print patron slips

This patch adds a very simple controller and template to allow patron
slip printing without all the boilerplate.

See bug 31713 for an example use.
Comment 2 Martin Renvoize 2022-10-10 11:19:38 UTC
Created attachment 141571 [details] [review]
Bug 31714: Add Generic way to print patron slips

This patch adds a very simple controller and template to allow patron
slip printing without all the boilerplate.

See bug 31713 for an example use.
Comment 3 David Nind 2022-10-10 20:29:07 UTC
Created attachment 141587 [details] [review]
Bug 31714: Add Generic way to print patron slips

This patch adds a very simple controller and template to allow patron
slip printing without all the boilerplate.

See bug 31713 for an example use.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-10-10 20:29:52 UTC
Tested using bug 31713.
Comment 5 Kyle M Hall 2022-10-21 12:24:51 UTC
Created attachment 142343 [details] [review]
Bug 31714: Add Generic way to print patron slips

This patch adds a very simple controller and template to allow patron
slip printing without all the boilerplate.

See bug 31713 for an example use.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi 2022-10-21 13:27:09 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!