Bug 31714 - Add a more generic way to print patron slips
Summary: Add a more generic way to print patron slips
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on:
Blocks: 32344 32345 32346 31713
  Show dependency tree / graph
 
Reported: 2022-10-07 15:28 UTC by Martin Renvoize (ashimema)
Modified: 2024-05-08 07:01 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This is a first step towards drying out our slip printing code. We add a new, modern, controller script that accepts any notice template to be passed to it for printing. Next steps would be to start migrating some of the old slips to use this controller and drop their respective controller scripts.
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 31714: Add Generic way to print patron slips (4.39 KB, patch)
2022-10-07 15:31 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 31714: Add Generic way to print patron slips (4.40 KB, patch)
2022-10-10 11:19 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 31714: Add Generic way to print patron slips (4.44 KB, patch)
2022-10-10 20:29 UTC, David Nind 		Details | Diff | Splinter Review
Bug 31714: Add Generic way to print patron slips (4.50 KB, patch)
2022-10-21 12:24 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2022-10-07 15:28:35 UTC 
Our slip printing code is somewhat spread out and custom per notice when in reality we could just have a simple controller passed a letter code and borrowernumber for many cases and then use TT notice templates to get all other details.
Comment 1 Martin Renvoize (ashimema) 2022-10-07 15:31:57 UTC 
Created attachment 141515 [details] [review]
Bug 31714: Add Generic way to print patron slips

This patch adds a very simple controller and template to allow patron
slip printing without all the boilerplate.

See bug 31713 for an example use.
Comment 2 Martin Renvoize (ashimema) 2022-10-10 11:19:38 UTC 
Created attachment 141571 [details] [review]
Bug 31714: Add Generic way to print patron slips

This patch adds a very simple controller and template to allow patron
slip printing without all the boilerplate.

See bug 31713 for an example use.
Comment 3 David Nind 2022-10-10 20:29:07 UTC 
Created attachment 141587 [details] [review]
Bug 31714: Add Generic way to print patron slips

This patch adds a very simple controller and template to allow patron
slip printing without all the boilerplate.

See bug 31713 for an example use.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-10-10 20:29:52 UTC 
Tested using bug 31713.
Comment 5 Kyle M Hall (khall) 2022-10-21 12:24:51 UTC 
Created attachment 142343 [details] [review]
Bug 31714: Add Generic way to print patron slips

This patch adds a very simple controller and template to allow patron
slip printing without all the boilerplate.

See bug 31713 for an example use.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Tomás Cohen Arazi (tcohen) 2022-10-21 13:27:09 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!