Bug 31829

Summary: Change password form in patron account is misaligned
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff interfaceAssignee: Lucas Gass <lucas>
Status: RESOLVED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: gmcharlt, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30952    
Bug Blocks: 35619    
Attachments: Bug 31829: Fix change password form alignment
Bug 31829: Fix change password form alignment
Bug 31829: Fix change password form alignment

Description Katrin Fischer 2022-10-16 11:53:10 UTC
As a side effect of the redesign work the "change password" form on the patron account in staff is misaligned.
Comment 1 Lucas Gass 2022-10-19 22:47:39 UTC
Created attachment 142215 [details] [review]
Bug 31829: Fix change password form alignment

This patch gives the fieldset on member-password.tt the class row. It also moves the hints below the list.

To test:
1. Apply patch
2. Pull up a patron record and go to 'Change password'.
3. Make sure the form now looks good.
4. Also check and make sure the form is still functional.
Comment 2 David Nind 2022-10-20 08:59:19 UTC
Created attachment 142234 [details] [review]
Bug 31829: Fix change password form alignment

This patch gives the fieldset on member-password.tt the class row. It also moves the hints below the list.

To test:
1. Apply patch
2. Pull up a patron record and go to 'Change password'.
3. Make sure the form now looks good.
4. Also check and make sure the form is still functional.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2022-10-21 09:26:11 UTC
Created attachment 142312 [details] [review]
Bug 31829: Fix change password form alignment

This patch gives the fieldset on member-password.tt the class row. It also moves the hints below the list.

To test:
1. Apply patch
2. Pull up a patron record and go to 'Change password'.
3. Make sure the form now looks good.
4. Also check and make sure the form is still functional.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Tomás Cohen Arazi 2022-10-21 12:59:08 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!