Bug 31829 - Change password form in patron account is misaligned
Summary: Change password form in patron account is misaligned
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 30952
Blocks: 35619
  Show dependency treegraph
 
Reported: 2022-10-16 11:53 UTC by Katrin Fischer
Modified: 2023-12-20 16:49 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31829: Fix change password form alignment (2.20 KB, patch)
2022-10-19 22:47 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31829: Fix change password form alignment (2.25 KB, patch)
2022-10-20 08:59 UTC, David Nind
Details | Diff | Splinter Review
Bug 31829: Fix change password form alignment (2.31 KB, patch)
2022-10-21 09:26 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-16 11:53:10 UTC
As a side effect of the redesign work the "change password" form on the patron account in staff is misaligned.
Comment 1 Lucas Gass 2022-10-19 22:47:39 UTC
Created attachment 142215 [details] [review]
Bug 31829: Fix change password form alignment

This patch gives the fieldset on member-password.tt the class row. It also moves the hints below the list.

To test:
1. Apply patch
2. Pull up a patron record and go to 'Change password'.
3. Make sure the form now looks good.
4. Also check and make sure the form is still functional.
Comment 2 David Nind 2022-10-20 08:59:19 UTC
Created attachment 142234 [details] [review]
Bug 31829: Fix change password form alignment

This patch gives the fieldset on member-password.tt the class row. It also moves the hints below the list.

To test:
1. Apply patch
2. Pull up a patron record and go to 'Change password'.
3. Make sure the form now looks good.
4. Also check and make sure the form is still functional.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2022-10-21 09:26:11 UTC
Created attachment 142312 [details] [review]
Bug 31829: Fix change password form alignment

This patch gives the fieldset on member-password.tt the class row. It also moves the hints below the list.

To test:
1. Apply patch
2. Pull up a patron record and go to 'Change password'.
3. Make sure the form now looks good.
4. Also check and make sure the form is still functional.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Tomás Cohen Arazi 2022-10-21 12:59:08 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!