Bug 35619 - Change password form in patron account has misaligned validation errors
Summary: Change password form in patron account has misaligned validation errors
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Lucas Gass
URL:
Keywords:
Depends on: 31829
Blocks:
  Show dependency treegraph
 
Reported: 2023-12-20 16:49 UTC by Owen Leonard
Modified: 2024-01-04 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08


Attachments
Bug 35619: Fix validation error alignment in change password form (2.50 KB, patch)
2023-12-20 16:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35619: Fix validation error alignment in change password form (2.55 KB, patch)
2023-12-20 21:19 UTC, David Nind
Details | Diff | Splinter Review
Bug 35619: Fix validation error alignment in change password form (2.60 KB, patch)
2023-12-21 21:35 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-12-20 16:49:25 UTC
Bug 31829 fixed the change password form layout but validation error messages are still misaligned.
Comment 1 Owen Leonard 2023-12-20 16:59:54 UTC
Created attachment 160132 [details] [review]
Bug 35619: Fix validation error alignment in change password form

Bug 31829 made a change to the change password form in the staff
interface to accommodate a gap in the CSS following the staff interface
redesign. This gap has been fixed, so we don't need a double class on
the fieldset.

With this change, the "hint" div can also be put back into place.

To test, apply the patch and locate a patron record in the staff
interface.

 - Click the "Change password" button on the patron detail page.
 - Confirm that the form layout looks correct.
 - Enter mismatched passwords in the "New password" and "Confirm new
   password" fields and click "Save"
   - The validation error message should be aligned to the right of the
     input field.
Comment 2 David Nind 2023-12-20 21:19:03 UTC
Created attachment 160168 [details] [review]
Bug 35619: Fix validation error alignment in change password form

Bug 31829 made a change to the change password form in the staff
interface to accommodate a gap in the CSS following the staff interface
redesign. This gap has been fixed, so we don't need a double class on
the fieldset.

With this change, the "hint" div can also be put back into place.

To test, apply the patch and locate a patron record in the staff
interface.

 - Click the "Change password" button on the patron detail page.
 - Confirm that the form layout looks correct.
 - Enter mismatched passwords in the "New password" and "Confirm new
   password" fields and click "Save"
   - The validation error message should be aligned to the right of the
     input field.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Lucas Gass 2023-12-21 21:35:40 UTC
Created attachment 160222 [details] [review]
Bug 35619: Fix validation error alignment in change password form

Bug 31829 made a change to the change password form in the staff
interface to accommodate a gap in the CSS following the staff interface
redesign. This gap has been fixed, so we don't need a double class on
the fieldset.

With this change, the "hint" div can also be put back into place.

To test, apply the patch and locate a patron record in the staff
interface.

 - Click the "Change password" button on the patron detail page.
 - Confirm that the form layout looks correct.
 - Enter mismatched passwords in the "New password" and "Confirm new
   password" fields and click "Save"
   - The validation error message should be aligned to the right of the
     input field.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Katrin Fischer 2023-12-27 18:10:27 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-01-03 15:36:21 UTC
Pushed to 23.11.x for 23.11.02
Comment 6 Lucas Gass 2024-01-04 21:04:27 UTC
Backported to 23.05.x for upcoming 23.05.08