Summary: | In check in page submit button should be yellow | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Templates | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31810 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31885 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
22.11.00
|
Circulation function: | |
Bug Depends on: | 30952 | ||
Bug Blocks: | 31947 | ||
Attachments: |
Bug 31884: Define 'check in' button as primary
Bug 31884: Define 'check in' button as primary Bug 31884: Define 'check in' button as primary |
Description
Fridolin Somers
2022-10-20 06:20:11 UTC
Created attachment 142225 [details] [review] Bug 31884: Define 'check in' button as primary Check in button in check in page is the most important action on this form, it should be yellow Test plan : 1) Go to check in page /cgi-bin/koha/circ/returns.pl 2) Check submit button 'Check in' as class 'btn-primary' and is yellow BTW maybe button text should be "Submit" like in renew page Created attachment 142228 [details] [review] Bug 31884: Define 'check in' button as primary Check in button in check in page is the most important action on this form, it should be yellow Test plan : 1) Go to check in page /cgi-bin/koha/circ/returns.pl 2) Check submit button 'Check in' as class 'btn-primary' and is yellow Signed-off-by: David Nind <david@davidnind.com> (In reply to Fridolin Somers from comment #2) > BTW maybe button text should be "Submit" like in renew page I'm not sure what Koha's convention is, but I generally prefer a specific label/action rather than a generic submit. Created attachment 142261 [details] [review] Bug 31884: Define 'check in' button as primary Check in button in check in page is the most important action on this form, it should be yellow Test plan : 1) Go to check in page /cgi-bin/koha/circ/returns.pl 2) Check submit button 'Check in' as class 'btn-primary' and is yellow Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! |