Summary: | No side menu when searching for syspref | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Staff interface | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, lucas, martin.renvoize, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
22.11.00
|
Circulation function: | |
Bug Depends on: | 31758 | ||
Bug Blocks: | 32065, 31917 | ||
Attachments: |
Bug 31886: Fix no sidebar problem in system pref search
Bug 31886: Fix no sidebar problem in system pref search Bug 31886: Fix no sidebar problem in system pref search Bug 31886: Fix no sidebar problem in system pref search Bug 31886: Fix no sidebar problem in system pref search |
Description
Jonathan Druart
2022-10-20 07:21:29 UTC
I think it is because of 'LINE.is_group_title'. And that has to do with how we format the .pref yaml files. This seems to happen when you search brings up i18n_l10n or serial system prefs. If we fix the YAML, I think we'll fix the problem. Created attachment 142289 [details] [review] Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. Created attachment 142335 [details] [review] Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Well spotted Lucas... I wonder if instead of repeating the title we should pick a appropriate subsection group title instead. Perhaps 'Global' or 'Features' or something like that.. So something like? * Serials - Features * I18N - Global Side note... it feels a bit weird that the 'You search for: TERM' is an H2 to me.. it means we end up with 'H1 > H2 > H2' and it doesn't stand out very well.. I'd be tempted to switch it to a span of some sort with it's own slightly different formatting? (In reply to Martin Renvoize from comment #4) > Well spotted Lucas... I wonder if instead of repeating the title we should > pick a appropriate subsection group title instead. > > Perhaps 'Global' or 'Features' or something like that.. > > So something like? > > * Serials - Features > * I18N - Global This seems reasonable to me, I'll make that change. Just moving out of queue until it bounces back with the follow-up :) Created attachment 142402 [details] [review] Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. Created attachment 142405 [details] [review] Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 142406 [details] [review] Bug 31886: Fix no sidebar problem in system pref search To test: 1. Go to Adminstration and click on 'Global system preferences' 2. From the left side bar click 'I18N/L10N' and notice no sidebar. 3. Also try 'Serials', no sidebar 4. Apply patch, restart_all 5. Try 1 & 2 again and the sidebar should be restored 6. Try clicking through each of the system preference groups (Accounting, Acquisitions, etc ) and make sure the sidebar is always present. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 22.11. Nice work everyone, thanks! It seems there is still some invalid YAML: https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/1639/consoleText Weird that only one build fails about this. Failing files touched by this ticket and bug 31952 (In reply to Victor Grousset/tuxayo from comment #12) > It seems there is still some invalid YAML: > https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/1639/ > consoleText > > Weird that only one build fails about this. > > Failing files touched by this ticket and bug 31952 Victor, Should we file a new bug for this? Ok, I wasn't sure if a follow-up could be made in the existing tickets: Bug 32065 |