When doing a system preference search we end up with two H2 headings directly after each other.. it doesn't feel quite right.
Created attachment 142407 [details] [review] Bug 31917: Headings fix for preferences search This patch re-arranges the logic for displaying the search term when executing a system preference search. Test plan 1) Without the patch, search for something that will get no results 'boing' and note how it looks 2) Without the patch, search for something that gets some results 'block' and note how it looks 3) Apply the patch 4) Repeat your searches and comment on whether the look is better of worse ;P
Created attachment 142472 [details] [review] Bug 31917: Headings fix for preferences search This patch re-arranges the logic for displaying the search term when executing a system preference search. Test plan 1) Without the patch, search for something that will get no results 'boing' and note how it looks 2) Without the patch, search for something that gets some results 'block' and note how it looks 3) Apply the patch 4) Repeat your searches and comment on whether the look is better of worse ;P Signed-off-by: David Nind <david@davidnind.com>
+1 - looks better
I am not sure about this one. It removes one h1 and adds 3 new h1... but apart from this, we are currently not consistent: * Catalog search: What you searched for displays below the unchanged heading * Patron search: what you searched for displays as part of the altered heading. I'd like to get another set of eyes on this one, Owen or Lukas maybe?
Created attachment 142532 [details] [review] Bug 31917: Headings fix for preferences search This patch re-arranges the logic for displaying the search term when executing a system preference search. Test plan 1) Without the patch, search for something that will get no results 'boing' and note how it looks 2) Without the patch, search for something that gets some results 'block' and note how it looks 3) Apply the patch 4) Repeat your searches and comment on whether the look is better of worse ;P Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
The template logic is a little more complex but I think the result is clearer.
Back to this one :) Thx, Owen!
Created attachment 142548 [details] [review] Bug 31917: Headings fix for preferences search This patch re-arranges the logic for displaying the search term when executing a system preference search. Test plan 1) Without the patch, search for something that will get no results 'boing' and note how it looks 2) Without the patch, search for something that gets some results 'block' and note how it looks 3) Apply the patch 4) Repeat your searches and comment on whether the look is better of worse ;P Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!