We need the page-section divs adding to the system preferences page to ensure proper contrast for even/odd rows on the tables. See https://github.com/jajm/koha-staff-interface-redesign/issues/55 for discusion.
Created attachment 141769 [details] [review] Bug 31758: OPTION 1 - Add page-section to prefs-tab div This patch simply adds the new page-section class to the existing prefs-tab div encasing the whole tab content inside a 'card' display.
Created attachment 141770 [details] [review] Bug 31758: OPTION 2 - Add page-section div around subsections An alternative that puts adds a new page-section div around each preference subsection rather than around the whole tab section.
Needs some input.. calling Owen :)
Option 1 just works.. Option 2 splits the content up more and 'might' be nicer.. but needs a little refinement still if people like it..
Created attachment 141793 [details] [review] Bug 31758: OPTION 2 (follow-up) Add padding between adjacent sections
My preference is option 2, with some padding between the sections.
Excellent follow-up Owen, thanks.. I think I prefer option 2 too... However, what do you think to what it does to the look of search results when you search for a system preference?.. It's not terrible, but also doesn't look quite right to me yet either... contemplating.
Also... if I do a search for a preference, say 'UserJS'.. if I then click through using the 'View all X preferences' link on the right of the section.. I end up with a larger top margin on the section I'm looking at.. seems to come from custom styling on 'h3:target'.. not sure how/what it was/is trying to achieve and whether we're safe to remove it now.
(In reply to Martin Renvoize from comment #7) > Excellent follow-up Owen, thanks.. I think I prefer option 2 too... > > However, what do you think to what it does to the look of search results > when you search for a system preference?.. It's not terrible, but also > doesn't look quite right to me yet either... contemplating. I also prefer option #2. When you search for system preferences and return more than 1 in a single category they look a bit "smushed" together. If there was just a tiny margin between the two I think it looks more organized. IMHO.
(In reply to Lucas Gass from comment #9) > (In reply to Martin Renvoize from comment #7) > > Excellent follow-up Owen, thanks.. I think I prefer option 2 too... > > > > However, what do you think to what it does to the look of search results > > when you search for a system preference?.. It's not terrible, but also > > doesn't look quite right to me yet either... contemplating. > > I also prefer option #2. > > When you search for system preferences and return more than 1 in a single > category they look a bit "smushed" together. If there was just a tiny margin > between the two I think it looks more organized. IMHO. Ignore my comment, this does create a nice margin. I didn't 'yarn build'.
Created attachment 141830 [details] [review] Bug 31758: OPTION 2 - Add page-section div around subsections An alternative that puts adds a new page-section div around each preference subsection rather than around the whole tab section. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 141831 [details] [review] Bug 31758: OPTION 2 (follow-up) Add padding between adjacent sections Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 141834 [details] [review] Bug 31758: (follow-up) Remove fat margin-top This removes the increased top margin appearing on subsection headings after clicking through from search.. I'm not sure if we need it or not now.. the original feature it appeared to help with doesn't work for me.. scroll to section doesn't happen.
(In reply to Martin Renvoize from comment #13) > Created attachment 141834 [details] [review] [review] > Bug 31758: (follow-up) Remove fat margin-top > > This removes the increased top margin appearing on subsection headings > after clicking through from search.. The purpose of the extra margin can be seen if you click one of the sidebar subheadings to jump down. Without the extra margin, when you jump to that section the heading is obscured by the floating toolbar.
(In reply to Owen Leonard from comment #14) > (In reply to Martin Renvoize from comment #13) > > Created attachment 141834 [details] [review] [review] [review] > > Bug 31758: (follow-up) Remove fat margin-top > > > > This removes the increased top margin appearing on subsection headings > > after clicking through from search.. > > The purpose of the extra margin can be seen if you click one of the sidebar > subheadings to jump down. Without the extra margin, when you jump to that > section the heading is obscured by the floating toolbar. I suggest we leave the last patch off for now, and then we could figure this one out still on a separate bug if we want.
Created attachment 141915 [details] [review] Bug 31758: OPTION 2 - Add page-section div around subsections An alternative that puts adds a new page-section div around each preference subsection rather than around the whole tab section. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 141916 [details] [review] Bug 31758: OPTION 2 (follow-up) Add padding between adjacent sections Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Good call obsoleting the third patch.. we probably should have a big for it though ;)
(In reply to Martin Renvoize from comment #18) > Good call obsoleting the third patch.. we probably should have a big for it > though ;) I left it open, because after Owen's explanation I was ok with the current behaviour.
Pushed to master for 22.11. Nice work everyone, thanks!