Summary: | Followup on Bug 32583 - fix some variable references | ||
---|---|---|---|
Product: | Koha | Reporter: | Michael Hafen <michael.hafen> |
Component: | Architecture, internals, and plumbing | Assignee: | Michael Hafen <michael.hafen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, fridolin.somers, jonathan.druart, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.05.00,22.11.04
|
Circulation function: | |
Bug Depends on: | 31315, 32583 | ||
Bug Blocks: | |||
Attachments: |
Bug 32585 - followup on Bug 32583 - fix some variable references
Bug 32585 - followup on Bug 32583 - fix some variable references Bug 32585: (bug 32583 follow-up) Fix some variable references |
Description
Michael Hafen
2023-01-06 23:10:30 UTC
Created attachment 145115 [details] [review] Bug 32585 - followup on Bug 32583 - fix some variable references Bug 32583 change the $item variable from a hash to an object. Trivial patch to change some hash references to object method calls. Created attachment 145228 [details] [review] Bug 32585 - followup on Bug 32583 - fix some variable references Bug 32583 change the $item variable from a hash to an object. Trivial patch to change some hash references to object method calls. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. I tested by first apply bug 32583 and then this bug. 2. I then repeated the test plan in bug 32583. I hope this is sufficient, otherwise let me know if any other tests are required. Created attachment 147236 [details] [review] Bug 32585: (bug 32583 follow-up) Fix some variable references Bug 32583 change the $item variable from a hash to an object. Trivial patch to change some hash references to object method calls. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Missing dependency for 22.05.x, no backport. |