Bug 31315 (Remove GetItemsInfo from moredetail) removed the code that limits the items displayed to only one item if the itemnumber was passed as a parameter to the page. This restores that code.
Created attachment 145109 [details] [review] Bug 32583 - Restore display of only one item in catalogue/moredetails Test plan: 1. find a title with multple items. 2. click on an items barcode in the holdings table on the title details page. 3. observe that all items are shown on the catalogue/moredetails page. 4. apply patch. 5. refresh (catalogue/moredetails) page. 6. observe that only the item for the barcode clicked on is shown.
Created attachment 145111 [details] [review] Bug 32583 - Restore display of only one item in catalogue/moredetails Test plan: 1. find a title with multple items. 2. click on an items barcode in the holdings table on the title details page. 3. observe that all items are shown on the catalogue/moredetails page. 4. apply patch. 5. refresh (catalogue/moredetails) page. 6. observe that only the item for the barcode clicked on is shown.
Created attachment 145227 [details] [review] Bug 32583 - Restore display of only one item in catalogue/moredetails Bug 31315 (Remove GetItemsInfo from moredetail) removed the code that limits the items displayed to only one item if the itemnumber was passed as a parameter to the page. This restores that code. Test plan: 1. find a title with multple items. 2. click on an items barcode in the holdings table on the title details page. 3. observe that all items are shown on the catalogue/moredetails page. 4. apply patch. 5. refresh (catalogue/moredetails) page. 6. observe that only the item for the barcode clicked on is shown. Signed-off-by: David Nind <david@davidnind.com>
+($itemnumber) and @items = (grep {$_->itemnumber == $itemnumber} @items); Please change into if statement for clearer code.
Created attachment 145299 [details] [review] Bug 32583 - Restore display of only one item in catalogue/moredetails Bug 31315 (Remove GetItemsInfo from moredetail) removed the code that limits the items displayed to only one item if the itemnumber was passed as a parameter to the page. This restores that code. Test plan: 1. find a title with multple items. 2. click on an items barcode in the holdings table on the title details page. 3. observe that all items are shown on the catalogue/moredetails page. 4. apply patch. 5. refresh (catalogue/moredetails) page. 6. observe that only the item for the barcode clicked on is shown.
Created attachment 145301 [details] [review] Bug 32583 - Restore display of only one item in catalogue/moredetails Bug 31315 (Remove GetItemsInfo from moredetail) removed the code that limits the items displayed to only one item if the itemnumber was passed as a parameter to the page. This restores that code. Test plan: 1. find a title with multple items. 2. click on an items barcode in the holdings table on the title details page. 3. observe that all items are shown on the catalogue/moredetails page. 4. apply patch. 5. refresh (catalogue/moredetails) page. 6. observe that only the item for the barcode clicked on is shown.
Created attachment 145585 [details] [review] Bug 32583 - Restore display of only one item in catalogue/moredetails Bug 31315 (Remove GetItemsInfo from moredetail) removed the code that limits the items displayed to only one item if the itemnumber was passed as a parameter to the page. This restores that code. Test plan: 1. find a title with multple items. 2. click on an items barcode in the holdings table on the title details page. 3. observe that all items are shown on the catalogue/moredetails page. 4. apply patch. 5. refresh (catalogue/moredetails) page. 6. observe that only the item for the barcode clicked on is shown. Signed-off-by: Amaury GAU <amaury.gau@bulac.fr>
Created attachment 145712 [details] [review] Bug 32583: Restore display of only one item in catalogue/moredetails Bug 31315 (Remove GetItemsInfo from moredetail) removed the code that limits the items displayed to only one item if the itemnumber was passed as a parameter to the page. This restores that code. Test plan: 1. find a title with multple items. 2. click on an items barcode in the holdings table on the title details page. 3. observe that all items are shown on the catalogue/moredetails page. 4. apply patch. 5. refresh (catalogue/moredetails) page. 6. observe that only the item for the barcode clicked on is shown. Signed-off-by: Amaury GAU <amaury.gau@bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x