Summary: | Reindent the invoice details page | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | lucas, martin.renvoize |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03
|
|
Bug Depends on: | |||
Bug Blocks: | 32746, 32769 | ||
Attachments: |
Bug 32743: Reindent the invoice details page
Bug 32743: (follow-up) Add markup comments Bug 32743: (follow-up) Add markup comments Bug 32743: Reindent the invoice details page Bug 32743: (follow-up) Add markup comments Bug 32743: Reindent the invoice details page Bug 32743: (follow-up) Add markup comments Bug 32743: Reindent the invoice details page Bug 32743: (follow-up) Add markup comments |
Description
Owen Leonard
2023-01-30 11:55:04 UTC
Created attachment 145797 [details] [review] Bug 32743: Reindent the invoice details page This patch reindents the invoice template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Acquisitions -> Invoices. - Perform a search which will return invoice results. - Click on an invoice to view the details. - Everything should look normal. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Created attachment 145798 [details] [review] Bug 32743: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 145833 [details] [review] Bug 32743: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 145885 [details] [review] Bug 32743: Reindent the invoice details page This patch reindents the invoice template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Acquisitions -> Invoices. - Perform a search which will return invoice results. - Click on an invoice to view the details. - Everything should look normal. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Created attachment 145886 [details] [review] Bug 32743: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 146043 [details] [review] Bug 32743: Reindent the invoice details page This patch reindents the invoice template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Acquisitions -> Invoices. - Perform a search which will return invoice results. - Click on an invoice to view the details. - Everything should look normal. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 146044 [details] [review] Bug 32743: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 146192 [details] [review] Bug 32743: Reindent the invoice details page This patch reindents the invoice template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and go to Acquisitions -> Invoices. - Perform a search which will return invoice results. - Click on an invoice to view the details. - Everything should look normal. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 146193 [details] [review] Bug 32743: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to master for 22.11.x Doesn't apply cleanly to 22.05.x, no backport. |