As per Bug 32744: Fieldsets with the class "action" should be placed outside of the fieldset containing the main body of the form. This report covers templates in administration.
Created attachment 145904 [details] [review] Bug 32769: Standardize structure around action fieldsets in administration This patch updates administration templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and check the following pages to confirm that the forms look correct: - Administration -> Keyboard shortcuts -> Audio alerts -> Share content with Mana KB - When the ManaToken system preference is empty, the page should have two forms with updated fieldsets: the form with the "Use Mana KB..." field and a "Configure Mana KB" form. - With a ManaToken defined the second form should be one labeled "Mana KB token." -> Budgets - Click on a budget which has existing funds. - In the page toolbar click Planning -> Plan by libraries. - Check the forms in the sidebar. -> System preferences -> OverDriveAuthName - Follow the link to "OverDrive library authnames table" and check the form on that page.
Created attachment 145956 [details] [review] Bug 32769: Standardize structure around action fieldsets in administration This patch updates administration templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and check the following pages to confirm that the forms look correct: - Administration -> Keyboard shortcuts -> Audio alerts -> Share content with Mana KB - When the ManaToken system preference is empty, the page should have two forms with updated fieldsets: the form with the "Use Mana KB..." field and a "Configure Mana KB" form. - With a ManaToken defined the second form should be one labeled "Mana KB token." -> Budgets - Click on a budget which has existing funds. - In the page toolbar click Planning -> Plan by libraries. - Check the forms in the sidebar. -> System preferences -> OverDriveAuthName - Follow the link to "OverDrive library authnames table" and check the form on that page. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This does what it says on the tin, but we still have some display inconsistencies, as sometimes the button is outside the page-section (shortcuts) and other times it's within (aqplan). Is this something we should look at now or better for later?
Created attachment 146213 [details] [review] Bug 32769: Standardize structure around action fieldsets in administration This patch updates administration templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and check the following pages to confirm that the forms look correct: - Administration -> Keyboard shortcuts -> Audio alerts -> Share content with Mana KB - When the ManaToken system preference is empty, the page should have two forms with updated fieldsets: the form with the "Use Mana KB..." field and a "Configure Mana KB" form. - With a ManaToken defined the second form should be one labeled "Mana KB token." -> Budgets - Click on a budget which has existing funds. - In the page toolbar click Planning -> Plan by libraries. - Check the forms in the sidebar. -> System preferences -> OverDriveAuthName - Follow the link to "OverDrive library authnames table" and check the form on that page. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Doesn't apply cleanly to 22.05.x, no backport.