Summary: | EnableItemGroups and EnableItemGroupHolds options are wrong | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | System Administration | Assignee: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, kyle, lucas |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04
|
|
Circulation function: | |||
Bug Depends on: | 24857, 24860 | ||
Bug Blocks: | |||
Attachments: |
Bug 32803 - EnableItemGroups and EnableItemGroupHolds options are wrong
Bug 32803 - EnableItemGroups and EnableItemGroupHolds options are wrong Bug 32803: EnableItemGroups and EnableItemGroupHolds options are wrong |
Description
Caroline Cyr La Rose
2023-02-02 16:49:34 UTC
The installer data (installer/data/mysql/mandatory/sysprefs.sql) and dbrevs (installer/data/mysql/db_revs/220600014.pl and installer/data/mysql/db_revs/220600078.pl) insert 0 for both by default. So I think that part is OK. It's only when you change them manually in the interface. Created attachment 146022 [details] [review] Bug 32803 - EnableItemGroups and EnableItemGroupHolds options are wrong This patch corrects the options for the EnableItemGroups and EnableItemGroupHolds system preferences. To test: 1. Enable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Enable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 2. Go to About Koha > System information --> There is a warning message 3. Go to a bibliographic record with at least one item --> The item group tab is displayed 4. Create an item group 4.1. Click New item group 4.2. Enter a name 4.3. Click Submit 4.4. In the Holdings tab, select the item 4.5. Click on Add/move to item group 4.6. Click Set item group 5. Place a hold on the item group 5.1. Click Place hold 5.2. Search for a patron 5.3. In the 'Hold next available item from an item group' section, select the item group 5.4. Click Place hold --> Placing a hold is possible 6. Disable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Disable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 7. Go to About Koha > System information --> There is a warning message 8. Apply patch 9. Redo steps 1 and 2 --> There is no warning 10. Redo step 3 --> The item group tab is displayed 11. Redo steps 4 and 5 --> Placing a hold is possible 12. Redo steps 6 and 7 --> There is no warning Created attachment 146263 [details] [review] Bug 32803 - EnableItemGroups and EnableItemGroupHolds options are wrong This patch corrects the options for the EnableItemGroups and EnableItemGroupHolds system preferences. To test: 1. Enable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Enable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 2. Go to About Koha > System information --> There is a warning message 3. Go to a bibliographic record with at least one item --> The item group tab is displayed 4. Create an item group 4.1. Click New item group 4.2. Enter a name 4.3. Click Submit 4.4. In the Holdings tab, select the item 4.5. Click on Add/move to item group 4.6. Click Set item group 5. Place a hold on the item group 5.1. Click Place hold 5.2. Search for a patron 5.3. In the 'Hold next available item from an item group' section, select the item group 5.4. Click Place hold --> Placing a hold is possible 6. Disable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Disable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 7. Go to About Koha > System information --> There is a warning message 8. Apply patch 9. Redo steps 1 and 2 --> There is no warning 10. Redo step 3 --> The item group tab is displayed 11. Redo steps 4 and 5 --> Placing a hold is possible 12. Redo steps 6 and 7 --> There is no warning Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 147209 [details] [review] Bug 32803: EnableItemGroups and EnableItemGroupHolds options are wrong This patch corrects the options for the EnableItemGroups and EnableItemGroupHolds system preferences. To test: 1. Enable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Enable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 2. Go to About Koha > System information --> There is a warning message 3. Go to a bibliographic record with at least one item --> The item group tab is displayed 4. Create an item group 4.1. Click New item group 4.2. Enter a name 4.3. Click Submit 4.4. In the Holdings tab, select the item 4.5. Click on Add/move to item group 4.6. Click Set item group 5. Place a hold on the item group 5.1. Click Place hold 5.2. Search for a patron 5.3. In the 'Hold next available item from an item group' section, select the item group 5.4. Click Place hold --> Placing a hold is possible 6. Disable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Disable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 7. Go to About Koha > System information --> There is a warning message 8. Apply patch 9. Redo steps 1 and 2 --> There is no warning 10. Redo step 3 --> The item group tab is displayed 11. Redo steps 4 and 5 --> Placing a hold is possible 12. Redo steps 6 and 7 --> There is no warning Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> JD Amended commit message: * Commit title does not start with 'Bug XXXXX: ' Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Missing dependencies for 22.05, no backport. |