Bug 24860 - Add ability to place volume level holds
Summary: Add ability to place volume level holds
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 24857
Blocks:
  Show dependency treegraph
 
Reported: 2020-03-12 15:45 UTC by Kyle M Hall
Modified: 2020-07-09 16:15 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 24860: Add reserves.volume_id (6.06 KB, patch)
2020-03-12 15:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Update existing Schema files [DO NOT PUSH] (6.53 KB, patch)
2020-03-12 15:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add new syspref EnableVolumeHolds (2.98 KB, patch)
2020-03-12 15:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Implement reserves.volume_id (3.64 KB, patch)
2020-03-12 15:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold (15.51 KB, patch)
2020-03-12 15:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold - OPAC (7.20 KB, patch)
2020-03-12 15:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in CheckReserves (2.73 KB, patch)
2020-03-12 15:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in HoldsQueue (7.88 KB, patch)
2020-03-12 15:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add reserves.volume_id (6.06 KB, patch)
2020-03-25 18:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add new syspref EnableVolumeHolds (2.98 KB, patch)
2020-03-25 18:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Implement reserves.volume_id (3.64 KB, patch)
2020-03-25 18:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold (15.44 KB, patch)
2020-03-25 18:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold - OPAC (7.16 KB, patch)
2020-03-25 18:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in CheckReserves (2.73 KB, patch)
2020-03-25 18:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in HoldsQueue (7.88 KB, patch)
2020-03-25 18:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Update existing Schema files [DO NOT PUSH] (4.69 KB, patch)
2020-03-25 18:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add reserves.volume_id (6.06 KB, patch)
2020-03-26 13:27 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add new syspref EnableVolumeHolds (2.98 KB, patch)
2020-03-26 13:27 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Implement reserves.volume_id (3.64 KB, patch)
2020-03-26 13:27 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold (16.27 KB, patch)
2020-03-26 13:27 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold - OPAC (7.16 KB, patch)
2020-03-26 13:27 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in CheckReserves (2.73 KB, patch)
2020-03-26 13:27 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in HoldsQueue (7.88 KB, patch)
2020-03-26 13:28 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Update existing Schema files [DO NOT PUSH] (4.69 KB, patch)
2020-03-26 13:28 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl (2.47 KB, patch)
2020-03-26 13:28 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add reserves.volume_id (6.06 KB, patch)
2020-04-01 17:32 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add new syspref EnableVolumeHolds (2.98 KB, patch)
2020-04-01 17:32 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Implement reserves.volume_id (3.64 KB, patch)
2020-04-01 17:32 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold (16.26 KB, patch)
2020-04-01 17:32 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold - OPAC (7.16 KB, patch)
2020-04-01 17:32 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in CheckReserves (2.75 KB, patch)
2020-04-01 17:32 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in HoldsQueue (7.88 KB, patch)
2020-04-01 17:32 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Update existing Schema files [DO NOT PUSH] (4.69 KB, patch)
2020-04-01 17:32 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl (2.47 KB, patch)
2020-04-01 17:33 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add reserves.volume_id (6.11 KB, patch)
2020-04-01 18:22 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Add new syspref EnableVolumeHolds (3.04 KB, patch)
2020-04-01 18:22 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Implement reserves.volume_id (3.71 KB, patch)
2020-04-01 18:22 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold (16.35 KB, patch)
2020-04-01 18:22 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold - OPAC (7.23 KB, patch)
2020-04-01 18:22 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in CheckReserves (2.80 KB, patch)
2020-04-01 18:22 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in HoldsQueue (7.94 KB, patch)
2020-04-01 18:22 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Update existing Schema files [DO NOT PUSH] (4.75 KB, patch)
2020-04-01 18:22 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl (2.51 KB, patch)
2020-04-01 18:22 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Add reserves.volume_id (6.13 KB, patch)
2020-07-06 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add new syspref EnableVolumeHolds (3.08 KB, patch)
2020-07-06 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Implement reserves.volume_id (3.71 KB, patch)
2020-07-06 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold (16.33 KB, patch)
2020-07-06 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold - OPAC (7.23 KB, patch)
2020-07-06 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in CheckReserves (2.82 KB, patch)
2020-07-06 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in HoldsQueue (7.95 KB, patch)
2020-07-06 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl (2.55 KB, patch)
2020-07-06 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Update existing Schema files [DO NOT PUSH] (4.72 KB, patch)
2020-07-06 16:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 24860: Add reserves.volume_id (6.15 KB, patch)
2020-07-09 08:33 UTC, Hugo Agud
Details | Diff | Splinter Review
Bug 24860: Add new syspref EnableVolumeHolds (3.12 KB, patch)
2020-07-09 08:33 UTC, Hugo Agud
Details | Diff | Splinter Review
Bug 24860: Implement reserves.volume_id (3.76 KB, patch)
2020-07-09 08:33 UTC, Hugo Agud
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold (16.39 KB, patch)
2020-07-09 08:33 UTC, Hugo Agud
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold - OPAC (7.27 KB, patch)
2020-07-09 08:33 UTC, Hugo Agud
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in CheckReserves (2.84 KB, patch)
2020-07-09 08:33 UTC, Hugo Agud
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in HoldsQueue (7.99 KB, patch)
2020-07-09 08:33 UTC, Hugo Agud
Details | Diff | Splinter Review
Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl (2.58 KB, patch)
2020-07-09 08:33 UTC, Hugo Agud
Details | Diff | Splinter Review
Bug 24860: Update existing Schema files [DO NOT PUSH] (4.75 KB, patch)
2020-07-09 08:34 UTC, Hugo Agud
Details | Diff | Splinter Review
Bug 24860: Add reserves.volume_id (6.21 KB, patch)
2020-07-09 16:15 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Add new syspref EnableVolumeHolds (3.18 KB, patch)
2020-07-09 16:15 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Implement reserves.volume_id (3.81 KB, patch)
2020-07-09 16:15 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold (16.45 KB, patch)
2020-07-09 16:15 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Add ability to select a volume when placing a hold - OPAC (7.32 KB, patch)
2020-07-09 16:15 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in CheckReserves (2.90 KB, patch)
2020-07-09 16:15 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Skip non-matching volume holds in HoldsQueue (8.04 KB, patch)
2020-07-09 16:15 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl (2.63 KB, patch)
2020-07-09 16:15 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 24860: Update existing Schema files [DO NOT PUSH] (4.80 KB, patch)
2020-07-09 16:15 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2020-03-12 15:45:49 UTC
This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).
Comment 1 Kyle M Hall 2020-03-12 15:58:15 UTC
Created attachment 100644 [details] [review]
Bug 24860: Add reserves.volume_id

This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and volumes, with each item being assigned to
a volume
6) Place a hold for a patron
7) Note the new selector to choose a volume in addition to record and item level holds
8) Place a volume level hold
9) Check in an item from the record that is not part of that volume
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that volume
12) Note the hold is trapped for that item
13) Place a volume level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that volume
16) Check out all the items of that volume to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable
Comment 2 Kyle M Hall 2020-03-12 15:58:24 UTC
Created attachment 100645 [details] [review]
Bug 24860: Update existing Schema files [DO NOT PUSH]
Comment 3 Kyle M Hall 2020-03-12 15:58:26 UTC
Created attachment 100646 [details] [review]
Bug 24860: Add new syspref EnableVolumeHolds
Comment 4 Kyle M Hall 2020-03-12 15:58:29 UTC
Created attachment 100647 [details] [review]
Bug 24860: Implement reserves.volume_id
Comment 5 Kyle M Hall 2020-03-12 15:58:32 UTC
Created attachment 100648 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold

TODO: Add 'Volume' column to holds table on circulation.pl and moremember.pl
      Requires embedding volume in hold API
Comment 6 Kyle M Hall 2020-03-12 15:58:34 UTC
Created attachment 100649 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold - OPAC
Comment 7 Kyle M Hall 2020-03-12 15:58:37 UTC
Created attachment 100650 [details] [review]
Bug 24860: Skip non-matching volume holds in CheckReserves
Comment 8 Kyle M Hall 2020-03-12 15:58:39 UTC
Created attachment 100651 [details] [review]
Bug 24860: Skip non-matching volume holds in HoldsQueue
Comment 9 Kyle M Hall 2020-03-25 18:00:23 UTC
Created attachment 101744 [details] [review]
Bug 24860: Add reserves.volume_id

This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and volumes, with each item being assigned to
a volume
6) Place a hold for a patron
7) Note the new selector to choose a volume in addition to record and item level holds
8) Place a volume level hold
9) Check in an item from the record that is not part of that volume
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that volume
12) Note the hold is trapped for that item
13) Place a volume level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that volume
16) Check out all the items of that volume to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable
Comment 10 Kyle M Hall 2020-03-25 18:00:32 UTC
Created attachment 101745 [details] [review]
Bug 24860: Add new syspref EnableVolumeHolds
Comment 11 Kyle M Hall 2020-03-25 18:00:34 UTC
Created attachment 101746 [details] [review]
Bug 24860: Implement reserves.volume_id
Comment 12 Kyle M Hall 2020-03-25 18:00:37 UTC
Created attachment 101747 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold

TODO: Add 'Volume' column to holds table on circulation.pl and moremember.pl
      Requires embedding volume in hold API
Comment 13 Kyle M Hall 2020-03-25 18:00:40 UTC
Created attachment 101748 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold - OPAC
Comment 14 Kyle M Hall 2020-03-25 18:00:42 UTC
Created attachment 101749 [details] [review]
Bug 24860: Skip non-matching volume holds in CheckReserves
Comment 15 Kyle M Hall 2020-03-25 18:00:45 UTC
Created attachment 101750 [details] [review]
Bug 24860: Skip non-matching volume holds in HoldsQueue
Comment 16 Kyle M Hall 2020-03-25 18:00:48 UTC
Created attachment 101751 [details] [review]
Bug 24860: Update existing Schema files [DO NOT PUSH]
Comment 17 Kyle M Hall 2020-03-26 13:27:38 UTC
Created attachment 101827 [details] [review]
Bug 24860: Add reserves.volume_id

This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and volumes, with each item being assigned to
a volume
6) Place a hold for a patron
7) Note the new selector to choose a volume in addition to record and item level holds
8) Place a volume level hold
9) Check in an item from the record that is not part of that volume
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that volume
12) Note the hold is trapped for that item
13) Place a volume level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that volume
16) Check out all the items of that volume to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable
Comment 18 Kyle M Hall 2020-03-26 13:27:47 UTC
Created attachment 101828 [details] [review]
Bug 24860: Add new syspref EnableVolumeHolds
Comment 19 Kyle M Hall 2020-03-26 13:27:49 UTC
Created attachment 101829 [details] [review]
Bug 24860: Implement reserves.volume_id
Comment 20 Kyle M Hall 2020-03-26 13:27:52 UTC
Created attachment 101830 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold
Comment 21 Kyle M Hall 2020-03-26 13:27:56 UTC
Created attachment 101831 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold - OPAC
Comment 22 Kyle M Hall 2020-03-26 13:27:58 UTC
Created attachment 101832 [details] [review]
Bug 24860: Skip non-matching volume holds in CheckReserves
Comment 23 Kyle M Hall 2020-03-26 13:28:01 UTC
Created attachment 101833 [details] [review]
Bug 24860: Skip non-matching volume holds in HoldsQueue
Comment 24 Kyle M Hall 2020-03-26 13:28:04 UTC
Created attachment 101834 [details] [review]
Bug 24860: Update existing Schema files [DO NOT PUSH]
Comment 25 Kyle M Hall 2020-03-26 13:28:06 UTC
Created attachment 101835 [details] [review]
Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl
Comment 26 Andrew Fuerste-Henry 2020-03-27 16:30:31 UTC
Receiving an ISE:
- find/create bib with 3 items
- put item_1 and item_2 in volume
- place hold on volume
- check in item_3
- get error:
Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 846
Comment 27 Kyle M Hall 2020-04-01 17:32:28 UTC
Created attachment 102230 [details] [review]
Bug 24860: Add reserves.volume_id

This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and volumes, with each item being assigned to
a volume
6) Place a hold for a patron
7) Note the new selector to choose a volume in addition to record and item level holds
8) Place a volume level hold
9) Check in an item from the record that is not part of that volume
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that volume
12) Note the hold is trapped for that item
13) Place a volume level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that volume
16) Check out all the items of that volume to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable
Comment 28 Kyle M Hall 2020-04-01 17:32:39 UTC
Created attachment 102231 [details] [review]
Bug 24860: Add new syspref EnableVolumeHolds
Comment 29 Kyle M Hall 2020-04-01 17:32:43 UTC
Created attachment 102232 [details] [review]
Bug 24860: Implement reserves.volume_id
Comment 30 Kyle M Hall 2020-04-01 17:32:46 UTC
Created attachment 102233 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold
Comment 31 Kyle M Hall 2020-04-01 17:32:49 UTC
Created attachment 102234 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold - OPAC
Comment 32 Kyle M Hall 2020-04-01 17:32:52 UTC
Created attachment 102235 [details] [review]
Bug 24860: Skip non-matching volume holds in CheckReserves
Comment 33 Kyle M Hall 2020-04-01 17:32:55 UTC
Created attachment 102236 [details] [review]
Bug 24860: Skip non-matching volume holds in HoldsQueue
Comment 34 Kyle M Hall 2020-04-01 17:32:59 UTC
Created attachment 102237 [details] [review]
Bug 24860: Update existing Schema files [DO NOT PUSH]
Comment 35 Kyle M Hall 2020-04-01 17:33:02 UTC
Created attachment 102238 [details] [review]
Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl
Comment 36 Andrew Fuerste-Henry 2020-04-01 18:22:11 UTC
Created attachment 102239 [details] [review]
Bug 24860: Add reserves.volume_id

This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and volumes, with each item being assigned to
a volume
6) Place a hold for a patron
7) Note the new selector to choose a volume in addition to record and item level holds
8) Place a volume level hold
9) Check in an item from the record that is not part of that volume
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that volume
12) Note the hold is trapped for that item
13) Place a volume level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that volume
16) Check out all the items of that volume to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 37 Andrew Fuerste-Henry 2020-04-01 18:22:16 UTC
Created attachment 102240 [details] [review]
Bug 24860: Add new syspref EnableVolumeHolds

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 38 Andrew Fuerste-Henry 2020-04-01 18:22:19 UTC
Created attachment 102241 [details] [review]
Bug 24860: Implement reserves.volume_id

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 39 Andrew Fuerste-Henry 2020-04-01 18:22:22 UTC
Created attachment 102242 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 40 Andrew Fuerste-Henry 2020-04-01 18:22:25 UTC
Created attachment 102243 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold - OPAC

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 41 Andrew Fuerste-Henry 2020-04-01 18:22:28 UTC
Created attachment 102244 [details] [review]
Bug 24860: Skip non-matching volume holds in CheckReserves

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 42 Andrew Fuerste-Henry 2020-04-01 18:22:32 UTC
Created attachment 102245 [details] [review]
Bug 24860: Skip non-matching volume holds in HoldsQueue

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 43 Andrew Fuerste-Henry 2020-04-01 18:22:35 UTC
Created attachment 102246 [details] [review]
Bug 24860: Update existing Schema files [DO NOT PUSH]

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 44 Andrew Fuerste-Henry 2020-04-01 18:22:38 UTC
Created attachment 102247 [details] [review]
Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 45 Kyle M Hall 2020-07-06 16:01:01 UTC
Created attachment 106589 [details] [review]
Bug 24860: Add reserves.volume_id

This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and volumes, with each item being assigned to
a volume
6) Place a hold for a patron
7) Note the new selector to choose a volume in addition to record and item level holds
8) Place a volume level hold
9) Check in an item from the record that is not part of that volume
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that volume
12) Note the hold is trapped for that item
13) Place a volume level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that volume
16) Check out all the items of that volume to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 46 Kyle M Hall 2020-07-06 16:01:18 UTC
Created attachment 106590 [details] [review]
Bug 24860: Add new syspref EnableVolumeHolds

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 47 Kyle M Hall 2020-07-06 16:01:21 UTC
Created attachment 106591 [details] [review]
Bug 24860: Implement reserves.volume_id

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 48 Kyle M Hall 2020-07-06 16:01:25 UTC
Created attachment 106592 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 49 Kyle M Hall 2020-07-06 16:01:28 UTC
Created attachment 106593 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold - OPAC

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 50 Kyle M Hall 2020-07-06 16:01:32 UTC
Created attachment 106594 [details] [review]
Bug 24860: Skip non-matching volume holds in CheckReserves

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 51 Kyle M Hall 2020-07-06 16:01:35 UTC
Created attachment 106595 [details] [review]
Bug 24860: Skip non-matching volume holds in HoldsQueue

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 52 Kyle M Hall 2020-07-06 16:01:39 UTC
Created attachment 106596 [details] [review]
Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 53 Kyle M Hall 2020-07-06 16:01:42 UTC
Created attachment 106597 [details] [review]
Bug 24860: Update existing Schema files [DO NOT PUSH]
Comment 54 Hugo Agud 2020-07-09 08:33:34 UTC
Created attachment 106682 [details] [review]
Bug 24860: Add reserves.volume_id

This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and volumes, with each item being assigned to
a volume
6) Place a hold for a patron
7) Note the new selector to choose a volume in addition to record and item level holds
8) Place a volume level hold
9) Check in an item from the record that is not part of that volume
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that volume
12) Note the hold is trapped for that item
13) Place a volume level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that volume
16) Check out all the items of that volume to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Hugo Agud (hagud@orex.es


Current status: Signed Off


 Current depends: 24857
Comment 55 Hugo Agud 2020-07-09 08:33:37 UTC
Created attachment 106683 [details] [review]
Bug 24860: Add new syspref EnableVolumeHolds

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>
Comment 56 Hugo Agud 2020-07-09 08:33:41 UTC
Created attachment 106684 [details] [review]
Bug 24860: Implement reserves.volume_id

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>
Comment 57 Hugo Agud 2020-07-09 08:33:45 UTC
Created attachment 106685 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>
Comment 58 Hugo Agud 2020-07-09 08:33:49 UTC
Created attachment 106686 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold - OPAC

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>
Comment 59 Hugo Agud 2020-07-09 08:33:52 UTC
Created attachment 106687 [details] [review]
Bug 24860: Skip non-matching volume holds in CheckReserves

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>
Comment 60 Hugo Agud 2020-07-09 08:33:56 UTC
Created attachment 106688 [details] [review]
Bug 24860: Skip non-matching volume holds in HoldsQueue

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>
Comment 61 Hugo Agud 2020-07-09 08:33:59 UTC
Created attachment 106689 [details] [review]
Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>
Comment 62 Hugo Agud 2020-07-09 08:34:04 UTC
Created attachment 106690 [details] [review]
Bug 24860: Update existing Schema files [DO NOT PUSH]

Signed-off-by: Your Full Name <your_email>
Comment 63 Hugo Agud 2020-07-09 08:47:07 UTC
I have already signed this patch, the patch does what it promises, but I wish to share some doubts.


When you talk about volume, you're talking about Bindings items? 

We only can add a volume to an intem if the items is not created, there is no way of assign volumes to already created items?

Volume is shown in a new colum, but in fact the value is also copied in enumchrom, that it can manage this and other values what happens if there is already another value at enumchrom?

At opac-detail at staff we are seeing twice de value (Volume and enumchrom), however at edit items page, we are not seeing volume column, just enumchron that it can be modified by a librarian without any problem.

There is no info on volume on opac-detail.tt page, then the user can't know there is a volume, although it can place a hold at volume level, without knowing anything

kindest regards
Comment 64 Andrew Fuerste-Henry 2020-07-09 16:15:19 UTC
Created attachment 106742 [details] [review]
Bug 24860: Add reserves.volume_id

This feature builds upon bug 24857 and allows placing holds that target a specific volume of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and volumes, with each item being assigned to
a volume
6) Place a hold for a patron
7) Note the new selector to choose a volume in addition to record and item level holds
8) Place a volume level hold
9) Check in an item from the record that is not part of that volume
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that volume
12) Note the hold is trapped for that item
13) Place a volume level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that volume
16) Check out all the items of that volume to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Comment 65 Andrew Fuerste-Henry 2020-07-09 16:15:23 UTC
Created attachment 106743 [details] [review]
Bug 24860: Add new syspref EnableVolumeHolds

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Comment 66 Andrew Fuerste-Henry 2020-07-09 16:15:27 UTC
Created attachment 106744 [details] [review]
Bug 24860: Implement reserves.volume_id

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Comment 67 Andrew Fuerste-Henry 2020-07-09 16:15:31 UTC
Created attachment 106745 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Comment 68 Andrew Fuerste-Henry 2020-07-09 16:15:35 UTC
Created attachment 106746 [details] [review]
Bug 24860: Add ability to select a volume when placing a hold - OPAC

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Comment 69 Andrew Fuerste-Henry 2020-07-09 16:15:39 UTC
Created attachment 106747 [details] [review]
Bug 24860: Skip non-matching volume holds in CheckReserves

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Comment 70 Andrew Fuerste-Henry 2020-07-09 16:15:42 UTC
Created attachment 106748 [details] [review]
Bug 24860: Skip non-matching volume holds in HoldsQueue

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Comment 71 Andrew Fuerste-Henry 2020-07-09 16:15:46 UTC
Created attachment 106749 [details] [review]
Bug 24860: Add hold's volume to holds table on circulation.pl and moremember.pl

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Your Full Name <your_email>

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Comment 72 Andrew Fuerste-Henry 2020-07-09 16:15:50 UTC
Created attachment 106750 [details] [review]
Bug 24860: Update existing Schema files [DO NOT PUSH]

Signed-off-by: Your Full Name <your_email>

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>