| Summary: | Fix cataloguing/value_builder/unimarc_field_125.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
| Component: | Cataloging | Assignee: | Julian Maurice <julian.maurice> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, m.de.rooy, phil, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.06,22.11.12
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 30975 | ||
| Attachments: |
Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl
Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl |
||
|
Description
Julian Maurice
2023-02-03 13:27:29 UTC
Created attachment 146118 [details] [review] Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Created attachment 146789 [details] [review] Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before I'm not familiar enough with UNIMARC to figure out how to use this plugin. Could you describe how to use this one? For example, which subfields to add this to, how to use it, and what it does. Thanks! David This works, but doesn't really seem to make sense. It's not linked by default anywhere and it uses the template of UNIMARC 100. Looking at the definition of 125 doesn't clear things up either. (https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf) What's the path forward here? All three of unimarc_field_124.pl, unimarc_field_125.pl, and unimarc_field_126.pl are the exact same thing, most likely from someone copying 100 and then realizing they needed separate ones for each subfield and forgetting to remove the non-subfield ones. Julian's patch for the 124 copy has already been pushed, and nothing bad has happened in the last five months as a result. Are we going to file a bug to remove all three plugins, or remove them in these bugs (including essentially reopening bug 32850 to remove 124), or push the patches here and in bug 32856 and then think about removing them? > Julian's patch for the 124 copy has already been pushed, and nothing bad has happened in the last five months as a result.
Nothing bad was reported for years even. Julian's patch doesn't even change a thing regarding the issue right? The problem Katrin found seems to have been like that for a long time.
(In reply to Katrin Fischer from comment #4) > This works, but doesn't really seem to make sense. > It's not linked by default anywhere and it uses the template of UNIMARC 100. > Looking at the definition of 125 doesn't clear things up either. > (https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf) Can this issue be moved to another bug report ? This is blocking bug 30975 and the patch doesn't change anything functionally (In reply to Julian Maurice from comment #7) > (In reply to Katrin Fischer from comment #4) > > This works, but doesn't really seem to make sense. > > It's not linked by default anywhere and it uses the template of UNIMARC 100. > > Looking at the definition of 125 doesn't clear things up either. > > (https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf) > > Can this issue be moved to another bug report ? This is blocking bug 30975 > and the patch doesn't change anything functionally Agreed, thx for bringing this up Julian. I filed: Bug 35184 - Consolidate UNIMARC value builders for 100, 124, 125, 125 Created attachment 158045 [details] [review] Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.06 Nice work everyone! Pushed to oldstable for 22.11.x |