Bug 32856 - Fix cataloguing/value_builder/unimarc_field_126.pl
Summary: Fix cataloguing/value_builder/unimarc_field_126.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency tree / graph
 
Reported: 2023-02-03 13:32 UTC by Julian Maurice
Modified: 2024-07-04 20:40 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12
Circulation function:

Attachments
Bug 32856: Fix cataloguing/value_builder/unimarc_field_126.pl (1.48 KB, patch)
2023-02-03 13:33 UTC, Julian Maurice 		Details | Diff | Splinter Review
Bug 32856: Fix cataloguing/value_builder/unimarc_field_126.pl (1.52 KB, patch)
2023-02-17 10:15 UTC, Julian Maurice 		Details | Diff | Splinter Review
Bug 32856: Fix cataloguing/value_builder/unimarc_field_126.pl (1.57 KB, patch)
2023-10-29 14:59 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 13:32:36 UTC 
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 13:33:46 UTC 
Created attachment 146121 [details] [review]
Bug 32856: Fix cataloguing/value_builder/unimarc_field_126.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-17 10:15:53 UTC 
Created attachment 146792 [details] [review]
Bug 32856: Fix cataloguing/value_builder/unimarc_field_126.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 3 David Nind 2023-03-26 17:00:25 UTC 
I'm not familiar enough with UNIMARC to figure out how to use this plugin.

Could you describe how to use this one? For example, which subfields to add this to, how to use it, and what it does.

Thanks!

David
Comment 4 Katrin Fischer 2023-04-22 22:00:40 UTC 
Hm, this, like bug 32853, uses the template for 100, but 125 doesn't look like that in the manual. Any hints?
Comment 5 Julian Maurice 2023-10-25 08:15:43 UTC 
(In reply to Katrin Fischer from comment #4)
> Hm, this, like bug 32853, uses the template for 100, but 125 doesn't look
> like that in the manual. Any hints?
Can this issue be moved to another bug report ? This is blocking bug 30975 and the patch doesn't change anything functionally
Comment 6 Katrin Fischer 2023-10-29 14:59:24 UTC 
(In reply to Julian Maurice from comment #5)
> (In reply to Katrin Fischer from comment #4)
> > Hm, this, like bug 32853, uses the template for 100, but 125 doesn't look
> > like that in the manual. Any hints?
> Can this issue be moved to another bug report ? This is blocking bug 30975
> and the patch doesn't change anything functionally

Agreed, thx for bringing this up Julian.

I filed:
Bug 35184 - Consolidate UNIMARC value builders for 100, 124, 125, 125
Comment 7 Katrin Fischer 2023-10-29 14:59:51 UTC 
Created attachment 158046 [details] [review]
Bug 32856: Fix cataloguing/value_builder/unimarc_field_126.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Tomás Cohen Arazi (tcohen) 2023-10-30 12:03:17 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-11-08 08:03:56 UTC 
Pushed to 23.05.x for 23.05.06
Comment 10 Matt Blenkinsop 2023-11-13 15:23:01 UTC 
Nice work everyone!

Pushed to oldstable for 22.11.x