Bug 32853 - Fix cataloguing/value_builder/unimarc_field_125.pl
Summary: Fix cataloguing/value_builder/unimarc_field_125.pl
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency treegraph
 
Reported: 2023-02-03 13:27 UTC by Julian Maurice
Modified: 2023-11-13 15:22 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12


Attachments
Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl (1.48 KB, patch)
2023-02-03 13:28 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl (1.52 KB, patch)
2023-02-17 10:15 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl (1.57 KB, patch)
2023-10-29 14:58 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 13:27:29 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 13:28:04 UTC
Created attachment 146118 [details] [review]
Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-17 10:15:19 UTC
Created attachment 146789 [details] [review]
Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 3 David Nind 2023-03-26 16:59:55 UTC
I'm not familiar enough with UNIMARC to figure out how to use this plugin.

Could you describe how to use this one? For example, which subfields to add this to, how to use it, and what it does.

Thanks!

David
Comment 4 Katrin Fischer 2023-04-22 21:56:55 UTC
This works, but doesn't really seem to make sense. 
It's not linked by default anywhere and it uses the template of UNIMARC 100.
Looking at the definition of 125 doesn't clear things up either. (https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf)
Comment 5 Phil Ringnalda 2023-08-11 22:33:25 UTC
What's the path forward here?

All three of unimarc_field_124.pl, unimarc_field_125.pl, and unimarc_field_126.pl are the exact same thing, most likely from someone copying 100 and then realizing they needed separate ones for each subfield and forgetting to remove the non-subfield ones. Julian's patch for the 124 copy has already been pushed, and nothing bad has happened in the last five months as a result.

Are we going to file a bug to remove all three plugins, or remove them in these bugs (including essentially reopening bug 32850 to remove 124), or push the patches here and in bug 32856 and then think about removing them?
Comment 6 Victor Grousset/tuxayo 2023-08-13 00:57:58 UTC
> Julian's patch for the 124 copy has already been pushed, and nothing bad has happened in the last five months as a result.

Nothing bad was reported for years even. Julian's patch doesn't even change a thing regarding the issue right? The problem Katrin found seems to have been like that for a long time.
Comment 7 Julian Maurice 2023-10-25 08:16:01 UTC
(In reply to Katrin Fischer from comment #4)
> This works, but doesn't really seem to make sense. 
> It's not linked by default anywhere and it uses the template of UNIMARC 100.
> Looking at the definition of 125 doesn't clear things up either.
> (https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf)

Can this issue be moved to another bug report ? This is blocking bug 30975 and the patch doesn't change anything functionally
Comment 8 Katrin Fischer 2023-10-29 14:57:34 UTC
(In reply to Julian Maurice from comment #7)
> (In reply to Katrin Fischer from comment #4)
> > This works, but doesn't really seem to make sense. 
> > It's not linked by default anywhere and it uses the template of UNIMARC 100.
> > Looking at the definition of 125 doesn't clear things up either.
> > (https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf)
> 
> Can this issue be moved to another bug report ? This is blocking bug 30975
> and the patch doesn't change anything functionally

Agreed, thx for bringing this up Julian.

I filed:
Bug 35184 - Consolidate UNIMARC value builders for 100, 124, 125, 125
Comment 9 Katrin Fischer 2023-10-29 14:58:09 UTC
Created attachment 158045 [details] [review]
Bug 32853: Fix cataloguing/value_builder/unimarc_field_125.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Tomás Cohen Arazi 2023-10-30 12:03:14 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 11 Fridolin Somers 2023-11-08 08:04:31 UTC
Pushed to 23.05.x for 23.05.06
Comment 12 Matt Blenkinsop 2023-11-13 15:22:58 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x