|
Description
Mason James
2023-02-17 12:58:36 UTC
Created attachment 146840 [details] [review] Bug 32609: Remove compiled files from src small patch for debian packaging no testing info provided (In reply to Mason James from comment #0) > small followup patch for bug 32609 this patch adds a file that stops dpkg-source from including ./node_modules dir to koha-common.deb package to test... - build a package, note failure - apply patch - build a package, note success Created attachment 146843 [details] [review] Bug 32609: Remove compiled files from src this patch adds a file that stops dpkg-source from including ./node_modules dir to koha-common.deb package to test... - build a package, note failure - apply patch - build a package, note success Created attachment 146932 [details] [review] Bug 32994: Remove compiled files from src (2) this patch adds 2 files that stops dpkg-source from including ./node_modules dir into koha-common.deb package to test... - build a package, note failure - apply patch - build a package, note success Created attachment 146933 [details] [review] Bug 32994: Remove compiled files from src (2) this patch adds 2 files that stops dpkg-source from including ./node_modules dir into koha-common.deb package to test... - build a package, note failure - apply patch - build a package, note success Created attachment 146994 [details] [review] Bug 32994 - remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL make[1]: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. make[1]: Leaving directory '/build/koha-22.12.00-4~git+20230221145053.b112630a' dh_auto_build: make -j1 returned exit code 2 make: *** [debian/rules:9: build] Error 2 dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 E: Failed autobuilding of package - apply patch - run makefile, note success version info below...
$ apt policy yarn:
*** 1.22.19-1 500
500 https://dl.yarnpkg.com/debian stable/main amd64 Packages
$ apt policy nodejs:
*** 14.21.3-deb-1nodesource1 999
500 https://deb.nodesource.com/node_14.x buster/main amd64 Packages
100 /var/lib/dpkg/status
$ npm -v
6.14.18
$ gulp -v
CLI version: 2.3.0
Local version: Unknown
Created attachment 146995 [details] [review] Bug 32994 - remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL $ make $ make install webpack 5.74.0 compiled with 3 warnings in 20831 ms Done in 36.01s. make: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. - apply patch - run makefile, note success With bug 32975 you shouldn't need the second patch. (In reply to Jonathan Druart from comment #9) > With bug 32975 you shouldn't need the second patch. hiya, i've confirmed 2nd patch is needed on latest HEAD 9863c18cc8 Bug 32933: Use val() instead of attr("value") when getting field values with jQuery Can we remove the lines instead of commenting? Also, are you running a dev install on packaging? the map files are only supposed to be generated when not using the :prod parameters, as those map files are only relevant on dev builds (they carry information about the scss file from which the css files were generated, for easier debugging). Can you post what you run on the build? Also, have you run git clean -f -x -d to make sure you don't have stray files? (In reply to Tomás Cohen Arazi from comment #11) > Can we remove the lines instead of commenting? > > Also, are you running a dev install on packaging? the map files are only > supposed to be generated when not using the :prod parameters, as those map > files are only relevant on dev builds (they carry information about the scss > file from which the css files were generated, for easier debugging). > > Can you post what you run on the build? Also, have you run git clean -f -x > -d to make sure you don't have stray files? note: no DEV_INSTALL=1 is set here is how i'm running a build... $ git clean -fdx $ git log --oneline | head -1 9863c18cc8 Bug 32933: Use val() instead of attr("value") when getting field values with jQuery $ git status On branch master Your branch is up to date with 'origin/master'. nothing to commit, working tree clean $ dpkg-buildpackage -b ... webpack 5.74.0 compiled with 3 warnings in 21555 ms Done in 36.15s. make[1]: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. make[1]: Leaving directory '/mnt/ssd4/pb-nightly/koha' dh_auto_build: make -j1 returned exit code 2 make: *** [debian/rules:9: build] Error 2 dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 Created attachment 147106 [details] [review] Bug 32994 - remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL $ make $ make install webpack 5.74.0 compiled with 3 warnings in 20831 ms Done in 36.01s. make: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. - apply patch - run makefile, note success (In reply to Tomás Cohen Arazi from comment #11) > Can we remove the lines instead of commenting? new patch uploaded with lines removed (In reply to Jonathan Druart from comment #9) > With bug 32975 you shouldn't need the second patch. aah, ive just clicked that 32975 isnt pushed (In reply to Mason James from comment #15) > (In reply to Jonathan Druart from comment #9) > > With bug 32975 you shouldn't need the second patch. > > aah, ive just clicked that 32975 isnt pushed confirmed package build fails with 32975 applied (In reply to Mason James from comment #15) > (In reply to Jonathan Druart from comment #9) > > With bug 32975 you shouldn't need the second patch. > > aah, ive just clicked that 32975 isnt pushed ignore this (In reply to Jonathan Druart from comment #9) > With bug 32975 you shouldn't need the second patch. Bug 32975 is probably the reason why the second patch is needed. I haven't double-checked but that would be my guess. (In reply to David Cook from comment #18) > (In reply to Jonathan Druart from comment #9) > > With bug 32975 you shouldn't need the second patch. > > Bug 32975 is probably the reason why the second patch is needed. I haven't > double-checked but that would be my guess. Indeed, I misread the patch. Looks like we are dealing with 2 different problems here. Would have been beteer to have 2 different bugs; Created attachment 147109 [details] [review] Bug 32994: Remove compiled files from src (2) this patch adds 2 files that stops dpkg-source from including ./node_modules dir into koha-common.deb package to test... - build a package, note failure - apply patch - build a package, note success Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147110 [details] [review] Bug 32994: Remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL $ make $ make install webpack 5.74.0 compiled with 3 warnings in 20831 ms Done in 36.01s. make: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. - apply patch - run makefile, note success Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147129 [details] [review] Bug 32994: Remove compiled files from src (2) this patch adds 2 files that stops dpkg-source from including ./node_modules dir into koha-common.deb package to test... - build a package, note failure - apply patch - build a package, note success Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 147130 [details] [review] Bug 32994: Remove breaking css/maps/*.map files from Makefile.PL to test: - run makefile, note failure $ perl Makefile.PL $ make $ make install webpack 5.74.0 compiled with 3 warnings in 20831 ms Done in 36.01s. make: *** No rule to make target 'koha-tmpl/opac-tmpl/bootstrap/css/maps/opac-rtl.css.map', needed by 'pm_to_blib'. Stop. - apply patch - run makefile, note success Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. *** Bug 33213 has been marked as a duplicate of this bug. *** Not needed in 22.05.x, no backport. |