package.json defines these commands: "css:build": "gulp css && gulp css --view opac", "css:build:prod": "gulp build && gulp css --view opac", The second one, css:build:prod is not running the "build" process for the OPAC. It should say "gulp build --view opac"
Created attachment 146700 [details] [review] Bug 32975: Error in package.json's definition of css:build vs css:build:prod The "css:build" command runs "gulp css && gulp css --view opac", processes that build CSS in a development context. The "css:build:prod" currently runs "gulp build && gulp css --view opac", which runs the production-oriented command "gulp build" (for the staff interface), but runs "gulp css --view opac" which is the same devel-environment command as above. It should be "gulp build && gulp build --view opac" To test, apply the patch and run the two commands and check these two files to confirm the difference: koha-tmpl/intranet-tmpl/prog/css/staff-global.css koha-tmpl/opac-tmpl/bootstra/css/opac.css "yarn css:build" should create unminimized versions of those files. "yarn css:build:prod" should create minimized versions.
Created attachment 146701 [details] [review] Bug 32975: Error in package.json's definition of css:build vs css:build:prod The "css:build" command runs "gulp css && gulp css --view opac", processes that build CSS in a development context. The "css:build:prod" currently runs "gulp build && gulp css --view opac", which runs the production-oriented command "gulp build" (for the staff interface), but runs "gulp css --view opac" which is the same devel-environment command as above. It should be "gulp build && gulp build --view opac" To test, apply the patch and run the two commands and check these two files to confirm the difference: koha-tmpl/intranet-tmpl/prog/css/staff-global.css koha-tmpl/opac-tmpl/bootstra/css/opac.css "yarn css:build" should create unminimized versions of those files. "yarn css:build:prod" should create minimized versions. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 146710 [details] [review] Bug 32975: Error in package.json's definition of css:build vs css:build:prod The "css:build" command runs "gulp css && gulp css --view opac", processes that build CSS in a development context. The "css:build:prod" currently runs "gulp build && gulp css --view opac", which runs the production-oriented command "gulp build" (for the staff interface), but runs "gulp css --view opac" which is the same devel-environment command as above. It should be "gulp build && gulp build --view opac" To test, apply the patch and run the two commands and check these two files to confirm the difference: koha-tmpl/intranet-tmpl/prog/css/staff-global.css koha-tmpl/opac-tmpl/bootstra/css/opac.css "yarn css:build" should create unminimized versions of those files. "yarn css:build:prod" should create minimized versions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Sorry about that, Owen. Thanks!
Pushed to master for 23.05. Nice work everyone, thanks!
(In reply to Tomás Cohen Arazi from comment #5) > Pushed to master for 23.05. this looks to be missing from master, can you push?
(In reply to Mason James from comment #6) > (In reply to Tomás Cohen Arazi from comment #5) > > Pushed to master for 23.05. > > this looks to be missing from master, can you push? oops ignore, now i see it bc43c6e7fe Bug 32975: Error in package.json's definition of css:build vs css:bui ld:prod
Dependency not in 22.11.x series.. no backport required.
We decided to backport the dependancy here and thus have now also backported this for 22.11.04 release
This seems to be backend stuff, nothing to be added to the manual. I will close, but feel free to add details as to what needs to be documented, and I will add it to the manual.