| Summary: | Add a message for from_local_hold_group override | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | emily.lamancusa, magnus |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 33052: Add a message for from_local_hold_group override
Bug 33052: Add a message for from_local_hold_group override Bug 33052: Fix typo |
||
|
Description
Kyle M Hall (khall)
2023-02-23 13:20:20 UTC
Created attachment 147231 [details] [review] Bug 33052: Add a message for from_local_hold_group override In reference to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860#c226 from_local_hold_group needs a message. Test Plan: 1) Overide a local group restricted hold, note there is no message 2) Apply this patch 3) Repeat step 1, note there is now a message! Looking at the patch, the message seems to be: This item normally cannot be put on hold out its' local hold group. Is that right? Should it be "out of" or something like that? Created attachment 153385 [details] [review] Bug 33052: Add a message for from_local_hold_group override In reference to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860#c226 from_local_hold_group needs a message. Test Plan: 1) Overide a local group restricted hold, note there is no message 2) Apply this patch 3) Repeat step 1, note there is now a message! Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Created attachment 153386 [details] [review] Bug 33052: Fix typo Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> I've not used hold groups much yet, some more hints on how to quickly set them up would be helpful here! I tried and failed to trigger the message: * Created a local hold group with Fairview and Fairfield * Created a record with 1 item: itemtype books, Fairfield * Added a circulation rule under all libraries with: Books - lokal holds group - any library - returns home * CircControl is: library the item is from * My user is from Centerville, I am trying to place a hod for myself in staff * I get: Cannot place hold from patron's library ... You also need to set AllowHoldPolicyOverride to true - then you should be able to select the item and trigger an override confirmation modal displaying the message. Trying again: * Set AllowHoldPolicyOverride to Allow * Created a local hold group with Fairview and Fairfield * Created a record with 1 item: itemtype Books, Fairfield * Added a circulation rule under all libraries with: Books - local holds group - any library - returns home * CircControl is: library the item is from * My user is from Centerville, I am trying to place a hod for myself in staff * I get: Cannot place hold from patron's library ... and now I can place the hold without any error - which honestly feels not right? Please retest yourself. |