Bug 33052 - Add a message for from_local_hold_group override
Summary: Add a message for from_local_hold_group override
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-23 13:20 UTC by Kyle M Hall
Modified: 2023-07-29 19:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 33052: Add a message for from_local_hold_group override (1.47 KB, patch)
2023-02-23 13:21 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 33052: Add a message for from_local_hold_group override (1.54 KB, patch)
2023-07-12 19:06 UTC, Emily Lamancusa
Details | Diff | Splinter Review
Bug 33052: Fix typo (1.42 KB, patch)
2023-07-12 19:06 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2023-02-23 13:20:20 UTC
In reference to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860#c226 from_local_hold_group needs a message.
Comment 1 Kyle M Hall 2023-02-23 13:21:37 UTC
Created attachment 147231 [details] [review]
Bug 33052: Add a message for from_local_hold_group override

In reference to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860#c226 from_local_hold_group needs a message.

Test Plan:
1) Overide a local group restricted hold, note there is no message
2) Apply this patch
3) Repeat step 1, note there is now a message!
Comment 2 Magnus Enger 2023-03-30 13:29:54 UTC
Looking at the patch, the message seems to be:

This item normally cannot be put on hold out its' local hold group.

Is that right? Should it be "out of" or something like that?
Comment 3 Emily Lamancusa 2023-07-12 19:06:49 UTC
Created attachment 153385 [details] [review]
Bug 33052: Add a message for from_local_hold_group override

In reference to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860#c226 from_local_hold_group needs a message.

Test Plan:
1) Overide a local group restricted hold, note there is no message
2) Apply this patch
3) Repeat step 1, note there is now a message!

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Emily Lamancusa 2023-07-12 19:06:52 UTC
Created attachment 153386 [details] [review]
Bug 33052: Fix typo

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 5 Katrin Fischer 2023-07-12 21:27:11 UTC
I've not used hold groups much yet, some more hints on how to quickly set them up would be helpful here!
Comment 6 Katrin Fischer 2023-07-12 21:38:43 UTC
I tried and failed to trigger the message:

* Created a local hold group with Fairview and Fairfield
* Created a record with 1 item: itemtype books, Fairfield
* Added a circulation rule  under all libraries with: 
  Books - lokal holds group - any library - returns home
* CircControl is: library the item is from
* My user is from Centerville, I am trying to place a hod for myself in staff
* I get: Cannot place hold from patron's library

...
Comment 7 Emily Lamancusa 2023-07-13 12:55:18 UTC
You also need to set AllowHoldPolicyOverride to true - then you should be able to select the item and trigger an override confirmation modal displaying the message.
Comment 8 Katrin Fischer 2023-07-29 19:24:30 UTC
Trying again:

* Set  AllowHoldPolicyOverride to Allow
* Created a local hold group with Fairview and Fairfield
* Created a record with 1 item: itemtype Books, Fairfield
* Added a circulation rule  under all libraries with: 
  Books - local holds group - any library - returns home
* CircControl is: library the item is from
* My user is from Centerville, I am trying to place a hod for myself in staff
* I get: Cannot place hold from patron's library

... and now I can place the hold without any error - which honestly feels not right?

Please retest yourself.