Bug 33235

Summary: Cypress tests are failing
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: Test SuiteAssignee: Pedro Amorim <pedro.amorim>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: jonathan.druart, lucas, martin.renvoize, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Bug Depends on: 32495, 32997    
Bug Blocks:    
Attachments: Bug 33235: Fix cypress tests
Bug 33235: Fix cypress tests

Description Pedro Amorim 2023-03-15 15:21:58 UTC

    
Comment 1 Pedro Amorim 2023-03-15 15:24:20 UTC
Created attachment 148219 [details] [review]
Bug 33235: Fix cypress tests

Some inconsistencies leftovers from 32495 and 32997 were causing cypress tests to fail, this fixes them.

* Apply patch
* Run cypress tests and verify all pass
Comment 2 Jonathan Druart 2023-03-17 10:01:02 UTC
It's fixing the problem, but I am getting some random failures.

    <testcase name="License CRUD operations Add license" time="0.0000" classname="Add license">     
      <failure message="Timed out retrying after 4000ms: Expected to find content: &apos;New license&apos; but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 4000ms: Expected t
o find content: 'New license' but never did.   



    <testcase name="Title CRUD operations Add title" time="0.0000" classname="Add title">                 
      <failure message="Timed out retrying after 4000ms: Expected to find element: `main div[class=&apos;dialog alert&apos;]`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying
 after 4000ms: Expected to find element: `main div[class='dialog alert']`, but never found it.            
    at Context.eval (http://kohadev-intra.mydnsname.org:8081/__cypress/tests?p=t/cypress/integration/Titles_spec.ts:304:12)]]></failure>  


Not related to this patch, but to keep in mind!
Comment 3 Jonathan Druart 2023-03-17 10:01:21 UTC
Created attachment 148319 [details] [review]
Bug 33235: Fix cypress tests

Some inconsistencies leftovers from 32495 and 32997 were causing cypress tests to fail, this fixes them.

* Apply patch
* Run cypress tests and verify all pass

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2023-03-17 10:02:19 UTC
Trivial and fix failing tests. Passing QA.
Comment 5 Tomás Cohen Arazi 2023-03-17 13:00:17 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-03-17 17:21:10 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass 2023-04-21 16:51:32 UTC
Not needed in 22.05.x, no backport