Created attachment 148219 [details] [review] Bug 33235: Fix cypress tests Some inconsistencies leftovers from 32495 and 32997 were causing cypress tests to fail, this fixes them. * Apply patch * Run cypress tests and verify all pass
It's fixing the problem, but I am getting some random failures. <testcase name="License CRUD operations Add license" time="0.0000" classname="Add license"> <failure message="Timed out retrying after 4000ms: Expected to find content: 'New license' but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 4000ms: Expected t o find content: 'New license' but never did. <testcase name="Title CRUD operations Add title" time="0.0000" classname="Add title"> <failure message="Timed out retrying after 4000ms: Expected to find element: `main div[class='dialog alert']`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 4000ms: Expected to find element: `main div[class='dialog alert']`, but never found it. at Context.eval (http://kohadev-intra.mydnsname.org:8081/__cypress/tests?p=t/cypress/integration/Titles_spec.ts:304:12)]]></failure> Not related to this patch, but to keep in mind!
Created attachment 148319 [details] [review] Bug 33235: Fix cypress tests Some inconsistencies leftovers from 32495 and 32997 were causing cypress tests to fail, this fixes them. * Apply patch * Run cypress tests and verify all pass Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Trivial and fix failing tests. Passing QA.
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x