Created attachment 148427 [details] [review] Bug 33282: Rename Dialog.spec.ts to Dialog_spec.ts
Created attachment 148428 [details] [review] Bug 33282: Remove redundant intercept
Created attachment 148429 [details] [review] Bug 33282: Move get_title to index.js to be invoked by different specs
Created attachment 148430 [details] [review] Bug 33282: Feed an array of titles so that no dialog message appears, including but not limited to the one we're testing for
This is not done yet, there's something weird happening with Packages_specs.ts. It doesn't fail running cypress open, but sometimes fails running cypress through CLI (headless), it's hard to pinpoint because it doesn't always fail. I think it's something to do with the loading dialog modal. Following the tests in the browser, the "Loading..." dialog modal is always present, and it seems to sometimes block a click() in Packages_specs.ts. Instead of just adding {force:true} to the click(), I'm trying to figure out why "Loading..." modal never stops showing with Cypress on the browser, but haven't figured it out yet.
(In reply to Pedro Amorim from comment #5) > This is not done yet, there's something weird happening with > Packages_specs.ts. > It doesn't fail running cypress open, but sometimes fails running cypress > through CLI (headless), it's hard to pinpoint because it doesn't always fail. > > I think it's something to do with the loading dialog modal. > Following the tests in the browser, the "Loading..." dialog modal is always > present, and it seems to sometimes block a click() in Packages_specs.ts. > Instead of just adding {force:true} to the click(), I'm trying to figure out > why "Loading..." modal never stops showing with Cypress on the browser, but > haven't figured it out yet. Weird! I've noticed a JS/DT error: "(alert) Something went wrong when loading the table. 200: OK." This is not expected. But it appears even when the tests pass.
Created attachment 148509 [details] [review] Bug 33282: Rename Dialog.spec.ts to Dialog_spec.ts Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 148510 [details] [review] Bug 33282: Remove useless intercept JD amended patch: replace "redundant" with "useless". It's not the same intercept, but we don't need the one removed by this patch. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 148511 [details] [review] Bug 33282: Move get_title to index.js to be invoked by different specs Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 148512 [details] [review] Bug 33282: Feed an array of titles so that no dialog message appears, including but not limited to the one we're testing for Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I've got the failure once (using cypress open), then no more. I think we should move forward with these patches, and fix the random failure separately.
Created attachment 148631 [details] [review] Bug 33282: Feed an array of titles so that no dialog message appears Including but not limited to the one we're testing for Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.05. We want jenkins happy to start the hackfest :)
Final follow-up pushed to 22.11.x for 22.11.04
oop.. wrong bug!.. ignore that.. this one is still in the queue
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Not needed in 22.05.x, no backport.