Bug 33494

Summary: Catalog concerns - Toggle 'Hide resolved' and 'Show all'
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: CatalogingAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: david, fridolin.somers, gmcharlt, m.de.rooy, philippe.blouin, r.delahunty
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33327
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/957
Text to go in the release notes:
**Sponsored by** *PTFS Europe*
Version(s) released in:
24.05.00
Circulation function:
Bug Depends on: 31028    
Bug Blocks: 35628    
Attachments: Bug 33494: Make filters a toggle
Bug 33494: Make filters a toggle
Bug 33494: Make filters a toggle
Bug 33494: Make filters a toggle
Bug 33494: Make filters a toggle

Description Caroline Cyr La Rose 2023-04-11 18:31:19 UTC
When viewing the Catalog concerns report (Cataloging > Catalog concerns), there are two links/buttons at the top of the page: Hide resolved and Show all. If all is already shown, 'Show all' is useless. Same thing with if 'Hide resolved' is clicked, this option becomes obsolete. Elsewhere in Koha (for example in Administration > Debit types), we offer 'Filter ...' and when that is clicked, the link changes to 'Show all ...'.

In the catalog concerns page, it should alternate between 'Filter resolved concerns' and 'Show all concerns'.
Comment 1 Caroline Cyr La Rose 2023-04-11 18:33:49 UTC
The icon should also probably be changed to the funnel, to match other places where there are filter/show all links.
Comment 2 Martin Renvoize (ashimema) 2023-12-27 16:02:05 UTC
Created attachment 160324 [details] [review]
Bug 33494: Make filters a toggle

This patch updates the markup to make the 'Filter resolved | Show all' a
toggle filter rather than two buttons.
Comment 3 Martin Renvoize (ashimema) 2023-12-27 16:03:34 UTC
*** Bug 33327 has been marked as a duplicate of this bug. ***
Comment 4 David Nind 2023-12-27 19:10:42 UTC
Created attachment 160328 [details] [review]
Bug 33494: Make filters a toggle

This patch updates the markup to make the 'Filter resolved | Show all' a
toggle filter rather than two buttons.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-12-27 19:16:04 UTC
Testing notes (using KTD):

1. Enable the CatalogConcerns system preference.

2. For two records, add a catalog concern (New > New catalog concern).

3. Resolve one of the concerns (Cataloging > Reports > Catalog concerns) - click on the 'Details' button then the 'Resolve' button.

4. Note that the filters at the top of the page are labelled: Hide resolved | Show all

5. Apply the patch and refresh the page.

6. Note that it is now a 'toggle': 'Include resolved' (default) or 'Filter resolved'
Comment 6 PTFS Europe Sandboxes 2024-02-27 10:30:17 UTC
Created attachment 162491 [details] [review]
Bug 33494: Make filters a toggle

This patch updates the markup to make the 'Filter resolved | Show all' a
toggle filter rather than two buttons.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 7 Martin Renvoize (ashimema) 2024-04-16 12:22:22 UTC
Created attachment 164911 [details] [review]
Bug 33494: Make filters a toggle

This patch updates the markup to make the 'Filter resolved | Show all' a
toggle filter rather than two buttons.

Test plan
1. Enable the CatalogConcerns system preference.
2. For two records, add a catalog concern (New > New catalog concern).
3. Resolve one of the concerns (Cataloging > Reports > Catalog concerns)
   - click on the 'Details' button then the 'Resolve' button.
4. Note that the filters at the top of the page are labelled: Hide
   resolved | Show all
5. Apply the patch and refresh the page.
6. Note that it is now a 'toggle': 'Include resolved' (default) or
   'Filter resolved'

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 8 Martin Renvoize (ashimema) 2024-04-16 12:22:44 UTC
Just a quick rebase, still ready for QA
Comment 9 Marcel de Rooy 2024-04-25 14:04:09 UTC
Created attachment 165546 [details] [review]
Bug 33494: Make filters a toggle

This patch updates the markup to make the 'Filter resolved | Show all' a
toggle filter rather than two buttons.

Test plan
1. Enable the CatalogConcerns system preference.
2. For two records, add a catalog concern (New > New catalog concern).
3. Resolve one of the concerns (Cataloging > Reports > Catalog concerns)
   - click on the 'Details' button then the 'Resolve' button.
4. Note that the filters at the top of the page are labelled: Hide
   resolved | Show all
5. Apply the patch and refresh the page.
6. Note that it is now a 'toggle': 'Include resolved' (default) or
   'Filter resolved'

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Katrin Fischer 2024-04-29 16:55:19 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 11 Fridolin Somers 2024-05-24 10:14:29 UTC
Not backported to 23.11.x