When viewing the Catalog concerns report (Cataloging > Catalog concerns), there are two links/buttons at the top of the page: Hide resolved and Show all. If all is already shown, 'Show all' is useless. Same thing with if 'Hide resolved' is clicked, this option becomes obsolete. Elsewhere in Koha (for example in Administration > Debit types), we offer 'Filter ...' and when that is clicked, the link changes to 'Show all ...'. In the catalog concerns page, it should alternate between 'Filter resolved concerns' and 'Show all concerns'.
The icon should also probably be changed to the funnel, to match other places where there are filter/show all links.
Created attachment 160324 [details] [review] Bug 33494: Make filters a toggle This patch updates the markup to make the 'Filter resolved | Show all' a toggle filter rather than two buttons.
*** Bug 33327 has been marked as a duplicate of this bug. ***
Created attachment 160328 [details] [review] Bug 33494: Make filters a toggle This patch updates the markup to make the 'Filter resolved | Show all' a toggle filter rather than two buttons. Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Enable the CatalogConcerns system preference. 2. For two records, add a catalog concern (New > New catalog concern). 3. Resolve one of the concerns (Cataloging > Reports > Catalog concerns) - click on the 'Details' button then the 'Resolve' button. 4. Note that the filters at the top of the page are labelled: Hide resolved | Show all 5. Apply the patch and refresh the page. 6. Note that it is now a 'toggle': 'Include resolved' (default) or 'Filter resolved'
Created attachment 162491 [details] [review] Bug 33494: Make filters a toggle This patch updates the markup to make the 'Filter resolved | Show all' a toggle filter rather than two buttons. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 164911 [details] [review] Bug 33494: Make filters a toggle This patch updates the markup to make the 'Filter resolved | Show all' a toggle filter rather than two buttons. Test plan 1. Enable the CatalogConcerns system preference. 2. For two records, add a catalog concern (New > New catalog concern). 3. Resolve one of the concerns (Cataloging > Reports > Catalog concerns) - click on the 'Details' button then the 'Resolve' button. 4. Note that the filters at the top of the page are labelled: Hide resolved | Show all 5. Apply the patch and refresh the page. 6. Note that it is now a 'toggle': 'Include resolved' (default) or 'Filter resolved' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Just a quick rebase, still ready for QA
Created attachment 165546 [details] [review] Bug 33494: Make filters a toggle This patch updates the markup to make the 'Filter resolved | Show all' a toggle filter rather than two buttons. Test plan 1. Enable the CatalogConcerns system preference. 2. For two records, add a catalog concern (New > New catalog concern). 3. Resolve one of the concerns (Cataloging > Reports > Catalog concerns) - click on the 'Details' button then the 'Resolve' button. 4. Note that the filters at the top of the page are labelled: Hide resolved | Show all 5. Apply the patch and refresh the page. 6. Note that it is now a 'toggle': 'Include resolved' (default) or 'Filter resolved' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.05! Well done everyone, thank you!
Not backported to 23.11.x