The catalog concerns system currently only supports 'open' and 'resolved' states. We should allow for a more fine-grained approach to these ticket workflows..
Created attachment 160255 [details] [review] Bug 35628: Add status to tickets table
Created attachment 160256 [details] [review] Bug 35628: Schema update
Created attachment 160257 [details] [review] Bug 35628: Add status to ticket definition
Created attachment 160258 [details] [review] Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above.
Created attachment 160259 [details] [review] Bug 35628: Display status in table appropriately
Created attachment 160268 [details] [review] Bug 35628: Add status to tickets table
Created attachment 160269 [details] [review] Bug 35628: Schema update
Created attachment 160270 [details] [review] Bug 35628: Add status to ticket definition
Created attachment 160271 [details] [review] Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above.
Created attachment 160272 [details] [review] Bug 35628: Display status strings instead of codes
Created attachment 160273 [details] [review] Bug 35628: Display status in table appropriately Signed-off-by: Esther <esther@bywatersolutions.com>
Created attachment 160274 [details] Status is cutoff The test plan does work, but the status is cut off in the modal window. Might need some adjustment.
Tha is for testing Esther, it looks like you just beat my final ammended patch here [U+1F60B]. I'm offline for Xmas now, but it look like if I obsolete your signed off patch you should be able to test again with the correct one applied. That final patch does two things, it fixes the overflow your spotted and also switches the display to use the description field of the authorized value instead of the coded one. Many thanks again for testing, it really motivated me to keep working on this series.
Note to self, add a class for status-* for each status to table rows in display so people can custom style different state tickets should they wish to.
Created attachment 160286 [details] [review] Bug 35628: Add status to tickets table Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160287 [details] [review] Bug 35628: Schema update Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160288 [details] [review] Bug 35628: Add status to ticket definition Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160289 [details] [review] Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above. Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160290 [details] [review] Bug 35628: Display status strings instead of codes Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160308 [details] [review] Bug 35628: Add current status as a class to table rows This patch adds the current status, if there is one set, to the table rows of the concerns interface.
Created attachment 160309 [details] [review] Bug 35628: Add status to tickets table Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160310 [details] [review] Bug 35628: Schema update Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160311 [details] [review] Bug 35628: Add status to ticket definition Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160312 [details] [review] Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above. Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160313 [details] [review] Bug 35628: Display status strings instead of codes Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160314 [details] [review] Bug 35628: Add current status as a class to table rows This patch adds the current status, if there is one set, to the table rows of the concerns interface.
Created attachment 160315 [details] [review] Bug 35628: Add status to tickets This patch adds a new TICKET_STATUS authorized value category as well as adding the new 'status' field to both 'tickets' and 'ticket_updates' tables. Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160316 [details] [review] Bug 35628: Schema update Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160317 [details] [review] Bug 35628: Add status to ticket definition Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160318 [details] [review] Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above. Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160319 [details] [review] Bug 35628: Display status strings instead of codes Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160320 [details] [review] Bug 35628: Add current status as a class to table rows This patch adds the current status, if there is one set, to the table rows of the concerns interface.
Created attachment 160329 [details] [review] Bug 35628: Add status to tickets This patch adds a new TICKET_STATUS authorized value category as well as adding the new 'status' field to both 'tickets' and 'ticket_updates' tables. Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160330 [details] [review] Bug 35628: Schema update Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160331 [details] [review] Bug 35628: Add status to ticket definition Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160332 [details] [review] Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above. Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160333 [details] [review] Bug 35628: Display status strings instead of codes Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 160334 [details] [review] Bug 35628: Add current status as a class to table rows This patch adds the current status, if there is one set, to the table rows of the concerns interface.
Created attachment 160335 [details] [review] Bug 35628: Add status filters to top bar This patch adds status filters to the top toolbar alongside the existing filter on resolved.
Created attachment 160364 [details] [review] Bug 35628: Add status filters to top bar This patch adds status filters to the top toolbar alongside the existing filter on resolved.
Created attachment 162500 [details] [review] Bug 35628: Add status filters to top bar This patch adds status filters to the top toolbar alongside the existing filter on resolved. Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 164912 [details] [review] Bug 35628: Add status to tickets This patch adds a new TICKET_STATUS authorized value category as well as adding the new 'status' field to both 'tickets' and 'ticket_updates' tables. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 164913 [details] [review] Bug 35628: Schema update Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 164914 [details] [review] Bug 35628: Add status to ticket definition Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 164915 [details] [review] Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 164916 [details] [review] Bug 35628: Display status strings instead of codes Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 164917 [details] [review] Bug 35628: Add current status as a class to table rows This patch adds the current status, if there is one set, to the table rows of the concerns interface. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 164918 [details] [review] Bug 35628: Add status filters to top bar This patch adds status filters to the top toolbar alongside the existing filter on resolved. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Quick rebase, ready for QA again.
Applying: Bug 35628: Display status strings instead of codes error: sha1 information is lacking or useless (api/v1/swagger/definitions/ticket.yaml). error: could not build fake ancestor
Created attachment 165551 [details] [review] Bug 35628: Add status to tickets This patch adds a new TICKET_STATUS authorized value category as well as adding the new 'status' field to both 'tickets' and 'ticket_updates' tables. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 165552 [details] [review] Bug 35628: Schema update Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 165553 [details] [review] Bug 35628: Add status to ticket definition Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 165554 [details] [review] Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 165555 [details] [review] Bug 35628: Display status strings instead of codes Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 165556 [details] [review] Bug 35628: Add current status as a class to table rows This patch adds the current status, if there is one set, to the table rows of the concerns interface. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 165557 [details] [review] Bug 35628: Add status filters to top bar This patch adds status filters to the top toolbar alongside the existing filter on resolved. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Created attachment 165560 [details] [review] Bug 35628: Unit tests for addition to tickets API This patch updates the unit test for the ticket_updates api to catch both the missing test 'state' for the existing state change functionality and also the new 'status' functionality introduced with this patchset. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 165561 [details] [review] Bug 35628: Add unit tests for Koha::Ticket addition We add a strings_map method to Koha::Ticket and thus need to have corresponding unit tests.
Created attachment 165562 [details] [review] Bug 35628: Add unit tests for Koha::Ticket::Update addition We add a strings_map method to Koha::Ticketi::Update and thus need to have corresponding unit tests.
Created attachment 165563 [details] [review] Bug 35628: Add unit tests for Koha::Ticket addition We add a strings_map method to Koha::Ticket and thus need to have corresponding unit tests.
Created attachment 165564 [details] [review] Bug 35628: Add unit tests for Koha::Ticket::Update addition We add a strings_map method to Koha::Ticketi::Update and thus need to have corresponding unit tests.
Looking here
Created attachment 165599 [details] [review] Bug 35628: Add status to tickets This patch adds a new TICKET_STATUS authorized value category as well as adding the new 'status' field to both 'tickets' and 'ticket_updates' tables. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165600 [details] [review] Bug 35628: Schema update Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165601 [details] [review] Bug 35628: Add status to ticket definition Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165602 [details] [review] Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165603 [details] [review] Bug 35628: Display status strings instead of codes Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165604 [details] [review] Bug 35628: Add current status as a class to table rows This patch adds the current status, if there is one set, to the table rows of the concerns interface. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165605 [details] [review] Bug 35628: Add status filters to top bar This patch adds status filters to the top toolbar alongside the existing filter on resolved. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165606 [details] [review] Bug 35628: Unit tests for addition to tickets API This patch updates the unit test for the ticket_updates api to catch both the missing test 'state' for the existing state change functionality and also the new 'status' functionality introduced with this patchset. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165607 [details] [review] Bug 35628: Add unit tests for Koha::Ticket addition We add a strings_map method to Koha::Ticket and thus need to have corresponding unit tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165608 [details] [review] Bug 35628: Add unit tests for Koha::Ticket::Update addition We add a strings_map method to Koha::Ticketi::Update and thus need to have corresponding unit tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Going to pass QA with some remarks (no blockers for me): FAIL installer/data/mysql/atomicupdate/bug_35628.pl FAIL file permissions File must have the exec flag WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 11) WARN t/db_dependent/api/v1/ticket_updates.t WARN tidiness The file is less tidy than before (bad/messy lines before: 57, now: 58) COMPARE + status: + type: + - string + - "null" + description: Current status of the ticket + readOnly: true WITH + status: + type: + - string + - "null" + description: Status of the ticket after this update => The first is readonly, the second is not. Just noting. + # Update ticket status if needed + if ( $ticket_update->{status} ) { + my $ticket = $update->ticket; + $ticket->set( { status => $ticket_update->{status} } )->store; + } Reading this the first time without deeper knowledge of the feature, these are quite confusing variable names. $update ? js if (o["!="] === '[% st.authorised_value | html %]') { additional_filters.status.push({ '!=': "[% st.authorised_value | html %]" }); No blocker. But using != here like this creates obscure code. General: Lots of patches here have no specific test plan. When I want to add a concern, it is hard to find how to. Not intuitive. Under the Concerns tab I should be able to add a new one.. (It is under New menu.) Updating status with custom ones is confusing. Display of the custom status on Ticket update looks suboptimal. If it is the intention to change the main status, the feature does not work as expected? Please improve on new follow-up reports?
Thanks for your time here Marcel. The QA script failures confuse me a little as they passed locally.. perhaps a patch mix up.. I'll double check that here now. As for the other comments, they're all reasonable and I'll create bugs for them so I can work through.. thanks so much for the review.
Created attachment 165622 [details] [review] Bug 35628: Add status to tickets This patch adds a new TICKET_STATUS authorized value category as well as adding the new 'status' field to both 'tickets' and 'ticket_updates' tables. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165623 [details] [review] Bug 35628: Schema update Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165624 [details] [review] Bug 35628: Add status to ticket definition Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165625 [details] [review] Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165626 [details] [review] Bug 35628: Display status strings instead of codes Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165627 [details] [review] Bug 35628: Add current status as a class to table rows This patch adds the current status, if there is one set, to the table rows of the concerns interface. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165628 [details] [review] Bug 35628: Add status filters to top bar This patch adds status filters to the top toolbar alongside the existing filter on resolved. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165629 [details] [review] Bug 35628: Unit tests for addition to tickets API This patch updates the unit test for the ticket_updates api to catch both the missing test 'state' for the existing state change functionality and also the new 'status' functionality introduced with this patchset. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165630 [details] [review] Bug 35628: Add unit tests for Koha::Ticket addition We add a strings_map method to Koha::Ticket and thus need to have corresponding unit tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165631 [details] [review] Bug 35628: Add unit tests for Koha::Ticket::Update addition We add a strings_map method to Koha::Ticket::Update and thus need to have corresponding unit tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
As suspected, the tidied and executable bit were fixed locally but somehow missed bugzilla.. I've redone them on your signed off set and re-uploaded.. QA script is now clean :)
Sorry, this doesn't apply. I am afraid the new tidying of JS files is to blame for the conflict. Too hard for me to resolve, but hopefully much easier when you know the code.
Created attachment 165770 [details] [review] Bug 35628: Add status to tickets This patch adds a new TICKET_STATUS authorized value category as well as adding the new 'status' field to both 'tickets' and 'ticket_updates' tables. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165771 [details] [review] Bug 35628: Schema update Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165772 [details] [review] Bug 35628: Add status to ticket definition Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165773 [details] [review] Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165774 [details] [review] Bug 35628: Display status strings instead of codes Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165775 [details] [review] Bug 35628: Add current status as a class to table rows This patch adds the current status, if there is one set, to the table rows of the concerns interface. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165776 [details] [review] Bug 35628: Add status filters to top bar This patch adds status filters to the top toolbar alongside the existing filter on resolved. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165777 [details] [review] Bug 35628: Unit tests for addition to tickets API This patch updates the unit test for the ticket_updates api to catch both the missing test 'state' for the existing state change functionality and also the new 'status' functionality introduced with this patchset. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165778 [details] [review] Bug 35628: Add unit tests for Koha::Ticket addition We add a strings_map method to Koha::Ticket and thus need to have corresponding unit tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165779 [details] [review] Bug 35628: Add unit tests for Koha::Ticket::Update addition We add a strings_map method to Koha::Ticket::Update and thus need to have corresponding unit tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.05! Well done everyone, thank you!
Not backported to 23.11.x