Bug 35628 - Add additional statuses to catalog concerns
Summary: Add additional statuses to catalog concerns
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 33494
Blocks: 32435 34324 36756
  Show dependency treegraph
 
Reported: 2023-12-21 11:43 UTC by Martin Renvoize
Modified: 2024-05-02 14:12 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00


Attachments
Bug 35628: Add status to tickets table (3.01 KB, patch)
2023-12-22 16:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Schema update (2.54 KB, patch)
2023-12-22 16:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to ticket definition (1.37 KB, patch)
2023-12-22 16:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add resolution states to Catalog concerns (7.32 KB, patch)
2023-12-22 16:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Display status in table appropriately (3.46 KB, patch)
2023-12-22 16:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to tickets table (3.01 KB, patch)
2023-12-22 17:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Schema update (2.54 KB, patch)
2023-12-22 17:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to ticket definition (1.37 KB, patch)
2023-12-22 17:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add resolution states to Catalog concerns (7.32 KB, patch)
2023-12-22 17:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Display status strings instead of codes (6.17 KB, patch)
2023-12-22 17:39 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Display status in table appropriately (3.50 KB, patch)
2023-12-22 17:53 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Status is cutoff (20.00 KB, image/png)
2023-12-22 17:55 UTC, Esther Melander
Details
Bug 35628: Add status to tickets table (3.07 KB, patch)
2023-12-24 08:18 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Schema update (2.59 KB, patch)
2023-12-24 08:18 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to ticket definition (1.43 KB, patch)
2023-12-24 08:18 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add resolution states to Catalog concerns (7.38 KB, patch)
2023-12-24 08:18 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Display status strings instead of codes (6.23 KB, patch)
2023-12-24 08:18 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add current status as a class to table rows (1.27 KB, patch)
2023-12-27 11:09 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to tickets table (3.65 KB, patch)
2023-12-27 11:17 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Schema update (2.59 KB, patch)
2023-12-27 11:17 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to ticket definition (1.43 KB, patch)
2023-12-27 11:18 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add resolution states to Catalog concerns (7.38 KB, patch)
2023-12-27 11:18 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Display status strings instead of codes (6.23 KB, patch)
2023-12-27 11:18 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add current status as a class to table rows (1.27 KB, patch)
2023-12-27 11:18 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to tickets (4.92 KB, patch)
2023-12-27 11:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Schema update (2.59 KB, patch)
2023-12-27 11:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to ticket definition (1.43 KB, patch)
2023-12-27 11:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add resolution states to Catalog concerns (7.38 KB, patch)
2023-12-27 11:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Display status strings instead of codes (6.23 KB, patch)
2023-12-27 11:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add current status as a class to table rows (1.27 KB, patch)
2023-12-27 11:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to tickets (4.92 KB, patch)
2023-12-28 10:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Schema update (2.59 KB, patch)
2023-12-28 10:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to ticket definition (1.43 KB, patch)
2023-12-28 10:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add resolution states to Catalog concerns (7.38 KB, patch)
2023-12-28 10:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Display status strings instead of codes (6.23 KB, patch)
2023-12-28 10:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add current status as a class to table rows (1.27 KB, patch)
2023-12-28 10:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status filters to top bar (4.18 KB, patch)
2023-12-28 10:06 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status filters to top bar (3.94 KB, patch)
2023-12-29 12:03 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status filters to top bar (3.99 KB, patch)
2024-02-27 11:56 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 35628: Add status to tickets (4.98 KB, patch)
2024-04-16 12:26 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Schema update (2.65 KB, patch)
2024-04-16 12:26 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to ticket definition (1.48 KB, patch)
2024-04-16 12:26 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add resolution states to Catalog concerns (7.43 KB, patch)
2024-04-16 12:26 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Display status strings instead of codes (6.29 KB, patch)
2024-04-16 12:26 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add current status as a class to table rows (1.38 KB, patch)
2024-04-16 12:26 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status filters to top bar (4.05 KB, patch)
2024-04-16 12:26 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to tickets (4.98 KB, patch)
2024-04-25 14:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Schema update (2.65 KB, patch)
2024-04-25 14:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to ticket definition (1.48 KB, patch)
2024-04-25 14:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add resolution states to Catalog concerns (7.43 KB, patch)
2024-04-25 14:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Display status strings instead of codes (6.29 KB, patch)
2024-04-25 14:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add current status as a class to table rows (1.38 KB, patch)
2024-04-25 14:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status filters to top bar (4.05 KB, patch)
2024-04-25 14:24 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Unit tests for addition to tickets API (2.56 KB, patch)
2024-04-25 15:13 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add unit tests for Koha::Ticket addition (2.32 KB, patch)
2024-04-25 15:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add unit tests for Koha::Ticket::Update addition (2.38 KB, patch)
2024-04-25 15:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add unit tests for Koha::Ticket addition (2.36 KB, patch)
2024-04-25 16:01 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add unit tests for Koha::Ticket::Update addition (2.42 KB, patch)
2024-04-25 16:01 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to tickets (5.07 KB, patch)
2024-04-26 07:08 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35628: Schema update (2.74 KB, patch)
2024-04-26 07:08 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35628: Add status to ticket definition (1.58 KB, patch)
2024-04-26 07:08 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35628: Add resolution states to Catalog concerns (7.52 KB, patch)
2024-04-26 07:08 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35628: Display status strings instead of codes (6.37 KB, patch)
2024-04-26 07:09 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35628: Add current status as a class to table rows (1.48 KB, patch)
2024-04-26 07:09 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35628: Add status filters to top bar (4.15 KB, patch)
2024-04-26 07:09 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35628: Unit tests for addition to tickets API (2.65 KB, patch)
2024-04-26 07:09 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35628: Add unit tests for Koha::Ticket addition (2.45 KB, patch)
2024-04-26 07:09 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35628: Add unit tests for Koha::Ticket::Update addition (2.51 KB, patch)
2024-04-26 07:09 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35628: Add status to tickets (5.14 KB, patch)
2024-04-26 09:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Schema update (2.70 KB, patch)
2024-04-26 09:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to ticket definition (1.54 KB, patch)
2024-04-26 09:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add resolution states to Catalog concerns (7.48 KB, patch)
2024-04-26 09:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Display status strings instead of codes (6.34 KB, patch)
2024-04-26 09:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add current status as a class to table rows (1.44 KB, patch)
2024-04-26 09:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status filters to top bar (4.11 KB, patch)
2024-04-26 09:36 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Unit tests for addition to tickets API (2.62 KB, patch)
2024-04-26 09:37 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add unit tests for Koha::Ticket addition (2.41 KB, patch)
2024-04-26 09:37 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add unit tests for Koha::Ticket::Update addition (2.47 KB, patch)
2024-04-26 09:37 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to tickets (5.14 KB, patch)
2024-04-29 17:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Schema update (2.70 KB, patch)
2024-04-29 17:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status to ticket definition (1.54 KB, patch)
2024-04-29 17:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add resolution states to Catalog concerns (7.15 KB, patch)
2024-04-29 17:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Display status strings instead of codes (6.38 KB, patch)
2024-04-29 17:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add current status as a class to table rows (1.44 KB, patch)
2024-04-29 17:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add status filters to top bar (4.11 KB, patch)
2024-04-29 17:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Unit tests for addition to tickets API (2.62 KB, patch)
2024-04-29 17:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add unit tests for Koha::Ticket addition (2.41 KB, patch)
2024-04-29 17:32 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35628: Add unit tests for Koha::Ticket::Update addition (2.47 KB, patch)
2024-04-29 17:32 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-12-21 11:43:26 UTC
The catalog concerns system currently only supports 'open' and 'resolved' states.  We should allow for a more fine-grained approach to these ticket workflows..
Comment 1 Martin Renvoize 2023-12-22 16:24:48 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2023-12-22 16:24:50 UTC Comment hidden (obsolete)
Comment 3 Martin Renvoize 2023-12-22 16:24:52 UTC Comment hidden (obsolete)
Comment 4 Martin Renvoize 2023-12-22 16:24:55 UTC Comment hidden (obsolete)
Comment 5 Martin Renvoize 2023-12-22 16:24:57 UTC Comment hidden (obsolete)
Comment 6 Martin Renvoize 2023-12-22 17:39:07 UTC Comment hidden (obsolete)
Comment 7 Martin Renvoize 2023-12-22 17:39:10 UTC Comment hidden (obsolete)
Comment 8 Martin Renvoize 2023-12-22 17:39:12 UTC Comment hidden (obsolete)
Comment 9 Martin Renvoize 2023-12-22 17:39:15 UTC Comment hidden (obsolete)
Comment 10 Martin Renvoize 2023-12-22 17:39:18 UTC Comment hidden (obsolete)
Comment 11 ByWater Sandboxes 2023-12-22 17:53:10 UTC Comment hidden (obsolete)
Comment 12 Esther Melander 2023-12-22 17:55:58 UTC
Created attachment 160274 [details]
Status is cutoff

The test plan does work, but the status is cut off in the modal window. Might need some adjustment.
Comment 13 Martin Renvoize 2023-12-23 09:04:58 UTC
Tha is for testing Esther, it looks like you just beat my final ammended patch here 😋.  I'm offline for Xmas now, but it look like if I obsolete your signed off patch you should be able to test again with the correct one applied.  That final patch does two things, it fixes the overflow your spotted and also switches the display to use the description field of the authorized value instead of the coded one.

Many thanks again for testing, it really motivated me to keep working on this series.
Comment 14 Martin Renvoize 2023-12-23 10:32:51 UTC
Note to self, add a class for status-* for each status to table rows in display so people can custom style different state tickets should they wish to.
Comment 15 Martin Renvoize 2023-12-24 08:18:34 UTC Comment hidden (obsolete)
Comment 16 Martin Renvoize 2023-12-24 08:18:37 UTC Comment hidden (obsolete)
Comment 17 Martin Renvoize 2023-12-24 08:18:40 UTC Comment hidden (obsolete)
Comment 18 Martin Renvoize 2023-12-24 08:18:42 UTC Comment hidden (obsolete)
Comment 19 Martin Renvoize 2023-12-24 08:18:45 UTC Comment hidden (obsolete)
Comment 20 Martin Renvoize 2023-12-27 11:09:36 UTC Comment hidden (obsolete)
Comment 21 Martin Renvoize 2023-12-27 11:17:56 UTC
Created attachment 160309 [details] [review]
Bug 35628: Add status to tickets table

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 22 Martin Renvoize 2023-12-27 11:17:59 UTC
Created attachment 160310 [details] [review]
Bug 35628: Schema update

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 23 Martin Renvoize 2023-12-27 11:18:01 UTC
Created attachment 160311 [details] [review]
Bug 35628: Add status to ticket definition

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 24 Martin Renvoize 2023-12-27 11:18:03 UTC
Created attachment 160312 [details] [review]
Bug 35628: Add resolution states to Catalog concerns

This patch adds ticket status to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_STATUS' authorized
values from which librarians can then pick at the point of updateing
a catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still update a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_STATUS authorized values
6) Submit a new catalog concern
7) Confirm that the 'Update' button in the management modal is now a
   split button with a dropdown containing the list of status values
   defined above.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 25 Martin Renvoize 2023-12-27 11:18:06 UTC
Created attachment 160313 [details] [review]
Bug 35628: Display status strings instead of codes

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 26 Martin Renvoize 2023-12-27 11:18:09 UTC
Created attachment 160314 [details] [review]
Bug 35628: Add current status as a class to table rows

This patch adds the current status, if there is one set, to the table
rows of the concerns interface.
Comment 27 Martin Renvoize 2023-12-27 11:34:37 UTC
Created attachment 160315 [details] [review]
Bug 35628: Add status to tickets

This patch adds a new TICKET_STATUS authorized value category as well as
adding the new 'status' field to both 'tickets' and 'ticket_updates'
tables.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 28 Martin Renvoize 2023-12-27 11:34:40 UTC
Created attachment 160316 [details] [review]
Bug 35628: Schema update

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 29 Martin Renvoize 2023-12-27 11:34:43 UTC
Created attachment 160317 [details] [review]
Bug 35628: Add status to ticket definition

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 30 Martin Renvoize 2023-12-27 11:34:46 UTC
Created attachment 160318 [details] [review]
Bug 35628: Add resolution states to Catalog concerns

This patch adds ticket status to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_STATUS' authorized
values from which librarians can then pick at the point of updateing
a catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still update a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_STATUS authorized values
6) Submit a new catalog concern
7) Confirm that the 'Update' button in the management modal is now a
   split button with a dropdown containing the list of status values
   defined above.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 31 Martin Renvoize 2023-12-27 11:34:49 UTC
Created attachment 160319 [details] [review]
Bug 35628: Display status strings instead of codes

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 32 Martin Renvoize 2023-12-27 11:34:52 UTC
Created attachment 160320 [details] [review]
Bug 35628: Add current status as a class to table rows

This patch adds the current status, if there is one set, to the table
rows of the concerns interface.
Comment 33 Martin Renvoize 2023-12-28 10:06:27 UTC
Created attachment 160329 [details] [review]
Bug 35628: Add status to tickets

This patch adds a new TICKET_STATUS authorized value category as well as
adding the new 'status' field to both 'tickets' and 'ticket_updates'
tables.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 34 Martin Renvoize 2023-12-28 10:06:30 UTC
Created attachment 160330 [details] [review]
Bug 35628: Schema update

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 35 Martin Renvoize 2023-12-28 10:06:33 UTC
Created attachment 160331 [details] [review]
Bug 35628: Add status to ticket definition

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 36 Martin Renvoize 2023-12-28 10:06:36 UTC
Created attachment 160332 [details] [review]
Bug 35628: Add resolution states to Catalog concerns

This patch adds ticket status to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_STATUS' authorized
values from which librarians can then pick at the point of updateing
a catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still update a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_STATUS authorized values
6) Submit a new catalog concern
7) Confirm that the 'Update' button in the management modal is now a
   split button with a dropdown containing the list of status values
   defined above.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 37 Martin Renvoize 2023-12-28 10:06:38 UTC
Created attachment 160333 [details] [review]
Bug 35628: Display status strings instead of codes

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Comment 38 Martin Renvoize 2023-12-28 10:06:41 UTC
Created attachment 160334 [details] [review]
Bug 35628: Add current status as a class to table rows

This patch adds the current status, if there is one set, to the table
rows of the concerns interface.
Comment 39 Martin Renvoize 2023-12-28 10:06:44 UTC
Created attachment 160335 [details] [review]
Bug 35628: Add status filters to top bar

This patch adds status filters to the top toolbar alongside the existing
filter on resolved.
Comment 40 Martin Renvoize 2023-12-29 12:03:21 UTC
Created attachment 160364 [details] [review]
Bug 35628: Add status filters to top bar

This patch adds status filters to the top toolbar alongside the existing
filter on resolved.
Comment 41 PTFS Europe Sandboxes 2024-02-27 11:56:00 UTC
Created attachment 162500 [details] [review]
Bug 35628: Add status filters to top bar

This patch adds status filters to the top toolbar alongside the existing
filter on resolved.

Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 42 Martin Renvoize 2024-04-16 12:26:31 UTC
Created attachment 164912 [details] [review]
Bug 35628: Add status to tickets

This patch adds a new TICKET_STATUS authorized value category as well as
adding the new 'status' field to both 'tickets' and 'ticket_updates'
tables.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 43 Martin Renvoize 2024-04-16 12:26:34 UTC
Created attachment 164913 [details] [review]
Bug 35628: Schema update

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 44 Martin Renvoize 2024-04-16 12:26:36 UTC
Created attachment 164914 [details] [review]
Bug 35628: Add status to ticket definition

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 45 Martin Renvoize 2024-04-16 12:26:39 UTC
Created attachment 164915 [details] [review]
Bug 35628: Add resolution states to Catalog concerns

This patch adds ticket status to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_STATUS' authorized
values from which librarians can then pick at the point of updateing
a catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still update a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_STATUS authorized values
6) Submit a new catalog concern
7) Confirm that the 'Update' button in the management modal is now a
   split button with a dropdown containing the list of status values
   defined above.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 46 Martin Renvoize 2024-04-16 12:26:42 UTC
Created attachment 164916 [details] [review]
Bug 35628: Display status strings instead of codes

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 47 Martin Renvoize 2024-04-16 12:26:45 UTC
Created attachment 164917 [details] [review]
Bug 35628: Add current status as a class to table rows

This patch adds the current status, if there is one set, to the table
rows of the concerns interface.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 48 Martin Renvoize 2024-04-16 12:26:48 UTC
Created attachment 164918 [details] [review]
Bug 35628: Add status filters to top bar

This patch adds status filters to the top toolbar alongside the existing
filter on resolved.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 49 Martin Renvoize 2024-04-16 12:27:05 UTC
Quick rebase, ready for QA again.
Comment 50 Marcel de Rooy 2024-04-25 14:06:21 UTC
Applying: Bug 35628: Display status strings instead of codes
error: sha1 information is lacking or useless (api/v1/swagger/definitions/ticket.yaml).
error: could not build fake ancestor
Comment 51 Martin Renvoize 2024-04-25 14:24:34 UTC
Created attachment 165551 [details] [review]
Bug 35628: Add status to tickets

This patch adds a new TICKET_STATUS authorized value category as well as
adding the new 'status' field to both 'tickets' and 'ticket_updates'
tables.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 52 Martin Renvoize 2024-04-25 14:24:36 UTC
Created attachment 165552 [details] [review]
Bug 35628: Schema update

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 53 Martin Renvoize 2024-04-25 14:24:40 UTC
Created attachment 165553 [details] [review]
Bug 35628: Add status to ticket definition

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 54 Martin Renvoize 2024-04-25 14:24:43 UTC
Created attachment 165554 [details] [review]
Bug 35628: Add resolution states to Catalog concerns

This patch adds ticket status to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_STATUS' authorized
values from which librarians can then pick at the point of updateing
a catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still update a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_STATUS authorized values
6) Submit a new catalog concern
7) Confirm that the 'Update' button in the management modal is now a
   split button with a dropdown containing the list of status values
   defined above.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 55 Martin Renvoize 2024-04-25 14:24:46 UTC
Created attachment 165555 [details] [review]
Bug 35628: Display status strings instead of codes

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 56 Martin Renvoize 2024-04-25 14:24:49 UTC
Created attachment 165556 [details] [review]
Bug 35628: Add current status as a class to table rows

This patch adds the current status, if there is one set, to the table
rows of the concerns interface.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 57 Martin Renvoize 2024-04-25 14:24:52 UTC
Created attachment 165557 [details] [review]
Bug 35628: Add status filters to top bar

This patch adds status filters to the top toolbar alongside the existing
filter on resolved.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 58 Martin Renvoize 2024-04-25 15:13:59 UTC
Created attachment 165560 [details] [review]
Bug 35628: Unit tests for addition to tickets API

This patch updates the unit test for the ticket_updates api to catch
both the missing test 'state' for the existing state change
functionality and also the new 'status' functionality introduced with
this patchset.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 59 Martin Renvoize 2024-04-25 15:34:18 UTC
Created attachment 165561 [details] [review]
Bug 35628: Add unit tests for Koha::Ticket addition

We add a strings_map method to Koha::Ticket and thus need to have
corresponding unit tests.
Comment 60 Martin Renvoize 2024-04-25 15:51:50 UTC
Created attachment 165562 [details] [review]
Bug 35628: Add unit tests for Koha::Ticket::Update addition

We add a strings_map method to Koha::Ticketi::Update and thus need
to have corresponding unit tests.
Comment 61 Martin Renvoize 2024-04-25 16:01:21 UTC
Created attachment 165563 [details] [review]
Bug 35628: Add unit tests for Koha::Ticket addition

We add a strings_map method to Koha::Ticket and thus need to have
corresponding unit tests.
Comment 62 Martin Renvoize 2024-04-25 16:01:24 UTC
Created attachment 165564 [details] [review]
Bug 35628: Add unit tests for Koha::Ticket::Update addition

We add a strings_map method to Koha::Ticketi::Update and thus need
to have corresponding unit tests.
Comment 63 Marcel de Rooy 2024-04-26 06:28:15 UTC
Looking here
Comment 64 Marcel de Rooy 2024-04-26 07:08:51 UTC
Created attachment 165599 [details] [review]
Bug 35628: Add status to tickets

This patch adds a new TICKET_STATUS authorized value category as well as
adding the new 'status' field to both 'tickets' and 'ticket_updates'
tables.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 65 Marcel de Rooy 2024-04-26 07:08:54 UTC
Created attachment 165600 [details] [review]
Bug 35628: Schema update

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 66 Marcel de Rooy 2024-04-26 07:08:56 UTC
Created attachment 165601 [details] [review]
Bug 35628: Add status to ticket definition

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 67 Marcel de Rooy 2024-04-26 07:08:59 UTC
Created attachment 165602 [details] [review]
Bug 35628: Add resolution states to Catalog concerns

This patch adds ticket status to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_STATUS' authorized
values from which librarians can then pick at the point of updateing
a catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still update a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_STATUS authorized values
6) Submit a new catalog concern
7) Confirm that the 'Update' button in the management modal is now a
   split button with a dropdown containing the list of status values
   defined above.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 68 Marcel de Rooy 2024-04-26 07:09:01 UTC
Created attachment 165603 [details] [review]
Bug 35628: Display status strings instead of codes

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 69 Marcel de Rooy 2024-04-26 07:09:04 UTC
Created attachment 165604 [details] [review]
Bug 35628: Add current status as a class to table rows

This patch adds the current status, if there is one set, to the table
rows of the concerns interface.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 70 Marcel de Rooy 2024-04-26 07:09:06 UTC
Created attachment 165605 [details] [review]
Bug 35628: Add status filters to top bar

This patch adds status filters to the top toolbar alongside the existing
filter on resolved.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 71 Marcel de Rooy 2024-04-26 07:09:09 UTC
Created attachment 165606 [details] [review]
Bug 35628: Unit tests for addition to tickets API

This patch updates the unit test for the ticket_updates api to catch
both the missing test 'state' for the existing state change
functionality and also the new 'status' functionality introduced with
this patchset.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 72 Marcel de Rooy 2024-04-26 07:09:12 UTC
Created attachment 165607 [details] [review]
Bug 35628: Add unit tests for Koha::Ticket addition

We add a strings_map method to Koha::Ticket and thus need to have
corresponding unit tests.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 73 Marcel de Rooy 2024-04-26 07:09:14 UTC
Created attachment 165608 [details] [review]
Bug 35628: Add unit tests for Koha::Ticket::Update addition

We add a strings_map method to Koha::Ticketi::Update and thus need
to have corresponding unit tests.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 74 Marcel de Rooy 2024-04-26 07:10:01 UTC
Going to pass QA with some remarks (no blockers for me):

 FAIL   installer/data/mysql/atomicupdate/bug_35628.pl
   FAIL   file permissions
                File must have the exec flag
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 0, now: 11)

 WARN   t/db_dependent/api/v1/ticket_updates.t
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 57, now: 58)

COMPARE
+  status:
+    type:
+      - string
+      - "null"
+    description: Current status of the ticket
+    readOnly: true
WITH
+  status:
+    type:
+      - string
+      - "null"
+    description: Status of the ticket after this update
=> The first is readonly, the second is not. Just noting.

+        # Update ticket status if needed
+        if ( $ticket_update->{status} ) {
+            my $ticket = $update->ticket;
+            $ticket->set( { status => $ticket_update->{status} } )->store;
+        }
Reading this the first time without deeper knowledge of the feature, these are quite confusing variable names. $update ?

js
if (o["!="] === '[% st.authorised_value | html %]') {
additional_filters.status.push({ '!=': "[% st.authorised_value | html %]" });
No blocker. But using != here like this creates obscure code.

General: 

Lots of patches here have no specific test plan.

When I want to add a concern, it is hard to find how to. Not intuitive. Under the Concerns tab I should be able to add a new one.. (It is under New menu.)

Updating status with custom ones is confusing. Display of the custom status on Ticket update looks suboptimal. If it is the intention to change the main status, the feature does not work as expected?

Please improve on new follow-up reports?
Comment 75 Martin Renvoize 2024-04-26 09:19:13 UTC
Thanks for your time here Marcel.

The QA script failures confuse me a little as they passed locally.. perhaps a patch mix up.. I'll double check that here now.

As for the other comments, they're all reasonable and I'll create bugs for them so I can work through.. thanks so much for the review.
Comment 76 Martin Renvoize 2024-04-26 09:36:40 UTC
Created attachment 165622 [details] [review]
Bug 35628: Add status to tickets

This patch adds a new TICKET_STATUS authorized value category as well as
adding the new 'status' field to both 'tickets' and 'ticket_updates'
tables.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 77 Martin Renvoize 2024-04-26 09:36:43 UTC
Created attachment 165623 [details] [review]
Bug 35628: Schema update

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 78 Martin Renvoize 2024-04-26 09:36:47 UTC
Created attachment 165624 [details] [review]
Bug 35628: Add status to ticket definition

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 79 Martin Renvoize 2024-04-26 09:36:50 UTC
Created attachment 165625 [details] [review]
Bug 35628: Add resolution states to Catalog concerns

This patch adds ticket status to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_STATUS' authorized
values from which librarians can then pick at the point of updateing
a catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still update a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_STATUS authorized values
6) Submit a new catalog concern
7) Confirm that the 'Update' button in the management modal is now a
   split button with a dropdown containing the list of status values
   defined above.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 80 Martin Renvoize 2024-04-26 09:36:53 UTC
Created attachment 165626 [details] [review]
Bug 35628: Display status strings instead of codes

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 81 Martin Renvoize 2024-04-26 09:36:56 UTC
Created attachment 165627 [details] [review]
Bug 35628: Add current status as a class to table rows

This patch adds the current status, if there is one set, to the table
rows of the concerns interface.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 82 Martin Renvoize 2024-04-26 09:36:59 UTC
Created attachment 165628 [details] [review]
Bug 35628: Add status filters to top bar

This patch adds status filters to the top toolbar alongside the existing
filter on resolved.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 83 Martin Renvoize 2024-04-26 09:37:02 UTC
Created attachment 165629 [details] [review]
Bug 35628: Unit tests for addition to tickets API

This patch updates the unit test for the ticket_updates api to catch
both the missing test 'state' for the existing state change
functionality and also the new 'status' functionality introduced with
this patchset.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 84 Martin Renvoize 2024-04-26 09:37:05 UTC
Created attachment 165630 [details] [review]
Bug 35628: Add unit tests for Koha::Ticket addition

We add a strings_map method to Koha::Ticket and thus need to have
corresponding unit tests.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 85 Martin Renvoize 2024-04-26 09:37:08 UTC
Created attachment 165631 [details] [review]
Bug 35628: Add unit tests for Koha::Ticket::Update addition

We add a strings_map method to Koha::Ticket::Update and thus need
to have corresponding unit tests.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 86 Martin Renvoize 2024-04-26 09:38:12 UTC
As suspected, the tidied and executable bit were fixed locally but somehow missed bugzilla.. I've redone them on your signed off set and re-uploaded.. QA script is now clean :)
Comment 87 Katrin Fischer 2024-04-29 16:39:20 UTC
Sorry, this doesn't apply. I am afraid the new tidying of JS files is to blame for the conflict. Too hard for me to resolve, but hopefully much easier when you know the code.
Comment 88 Martin Renvoize 2024-04-29 17:32:28 UTC
Created attachment 165770 [details] [review]
Bug 35628: Add status to tickets

This patch adds a new TICKET_STATUS authorized value category as well as
adding the new 'status' field to both 'tickets' and 'ticket_updates'
tables.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 89 Martin Renvoize 2024-04-29 17:32:31 UTC
Created attachment 165771 [details] [review]
Bug 35628: Schema update

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 90 Martin Renvoize 2024-04-29 17:32:34 UTC
Created attachment 165772 [details] [review]
Bug 35628: Add status to ticket definition

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 91 Martin Renvoize 2024-04-29 17:32:38 UTC
Created attachment 165773 [details] [review]
Bug 35628: Add resolution states to Catalog concerns

This patch adds ticket status to the catalog concerns feature. It
allows libraries to define a list of 'TICKET_STATUS' authorized
values from which librarians can then pick at the point of updateing
a catalog concern.

To test:
1) Apply the patches and run the database updates
2) Enable catalog concerns (staff or opac will do the trick)
3) Submit a catalog concern
4) Confirm that you can still update a concern from the catalog
   concerns management page as before.
5) Add some values to the new TICKET_STATUS authorized values
6) Submit a new catalog concern
7) Confirm that the 'Update' button in the management modal is now a
   split button with a dropdown containing the list of status values
   defined above.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 92 Martin Renvoize 2024-04-29 17:32:42 UTC
Created attachment 165774 [details] [review]
Bug 35628: Display status strings instead of codes

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 93 Martin Renvoize 2024-04-29 17:32:45 UTC
Created attachment 165775 [details] [review]
Bug 35628: Add current status as a class to table rows

This patch adds the current status, if there is one set, to the table
rows of the concerns interface.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 94 Martin Renvoize 2024-04-29 17:32:48 UTC
Created attachment 165776 [details] [review]
Bug 35628: Add status filters to top bar

This patch adds status filters to the top toolbar alongside the existing
filter on resolved.

Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 95 Martin Renvoize 2024-04-29 17:32:51 UTC
Created attachment 165777 [details] [review]
Bug 35628: Unit tests for addition to tickets API

This patch updates the unit test for the ticket_updates api to catch
both the missing test 'state' for the existing state change
functionality and also the new 'status' functionality introduced with
this patchset.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 96 Martin Renvoize 2024-04-29 17:32:54 UTC
Created attachment 165778 [details] [review]
Bug 35628: Add unit tests for Koha::Ticket addition

We add a strings_map method to Koha::Ticket and thus need to have
corresponding unit tests.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 97 Martin Renvoize 2024-04-29 17:32:57 UTC
Created attachment 165779 [details] [review]
Bug 35628: Add unit tests for Koha::Ticket::Update addition

We add a strings_map method to Koha::Ticket::Update and thus need
to have corresponding unit tests.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 98 Katrin Fischer 2024-04-30 10:01:51 UTC
Pushed for 24.05!

Well done everyone, thank you!