Summary: | Batch patron modification broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Tools | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.05.00,22.11.06
|
Circulation function: | |
Bug Depends on: | 33324 | ||
Bug Blocks: | |||
Attachments: |
Bug 33637: Update tab ids for batch modification form
Bug 33637: Update tab ids for batch modification form Bug 33637: Update tab ids for batch modification form |
Description
Nick Clemens (kidclamp)
2023-04-28 15:56:51 UTC
Created attachment 150394 [details] [review] Bug 33637: Update tab ids for batch modification form This patch adjusts the ids in the submit function To test: 1 - Browse to tools -> Batch patron modification 2 - Enter cardnumbers and submit 3 - No patrons 4 - Enter borrowernumbers and submit 5 - No patrons 6 - Apply patch 7 - Repeat 8 - Success, patrons are listed Created attachment 150418 [details] [review] Bug 33637: Update tab ids for batch modification form This patch adjusts the ids in the submit function To test: 1 - Browse to tools -> Batch patron modification 2 - Enter cardnumbers and submit 3 - No patrons 4 - Enter borrowernumbers and submit 5 - No patrons 6 - Apply patch 7 - Repeat 8 - Success, patrons are listed Signed-off-by: David Nind <david@davidnind.com> This looks like a duplicate of bug 33638 - I'll leave it to the patch authors to decide which is the 'best' solution 8-). Kidclamp's is better. :) *** Bug 33638 has been marked as a duplicate of this bug. *** Trivial fix, changes make perfect sense, QA script is happy. Created attachment 150421 [details] [review] Bug 33637: Update tab ids for batch modification form This patch adjusts the ids in the submit function To test: 1 - Browse to tools -> Batch patron modification 2 - Enter cardnumbers and submit 3 - No patrons 4 - Enter borrowernumbers and submit 5 - No patrons 6 - Apply patch 7 - Repeat 8 - Success, patrons are listed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release Not needed in 22.05.x |