Bug 33638 - Batch patron modification is broken
Summary: Batch patron modification is broken
Status: RESOLVED DUPLICATE of bug 33637
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-28 17:56 UTC by Lucas Gass
Modified: 2023-04-28 20:21 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 33638: Fix if statement in modborrowers.tt (1.70 KB, patch)
2023-04-28 18:18 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33638: Fix if statement in modborrowers.tt (1.77 KB, patch)
2023-04-28 18:25 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-04-28 17:56:37 UTC
While testing Bug 33582 I noticed that Batch patron modification seems to be broken:

To recreate:
1. Get some valid cardnumbers and borrowernumbers 
2. Go to Tools > Batch patron modification
3. Try entering either cardnumbers or borrowernumbers. 

Even with valid cardnumbers or borrowernumbers I get:


No patron card numbers or borrowernumbers given.
Comment 1 Lucas Gass 2023-04-28 18:18:04 UTC
Created attachment 150409 [details] [review]
Bug 33638: Fix if statement in modborrowers.tt

To test:

1. Get some valid cardnumbers and borrowernumbers
2. Go to Tools > Batch patron modification
3. Try entering either cardnumbers or borrowernumbers.
4. Apply patch
5. Try again, now it should work.
6. Make sure it works for both cardnumbers and borrowernumbers.
Comment 2 PTFS Europe Sandboxes 2023-04-28 18:25:15 UTC
Created attachment 150410 [details] [review]
Bug 33638: Fix if statement in modborrowers.tt

To test:

1. Get some valid cardnumbers and borrowernumbers
2. Go to Tools > Batch patron modification
3. Try entering either cardnumbers or borrowernumbers.
4. Apply patch
5. Try again, now it should work.
6. Make sure it works for both cardnumbers and borrowernumbers.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 David Nind 2023-04-28 19:11:06 UTC
This looks like a duplicate of bug 33637 - I'll leave it to the patch authors to decide which is the 'best' solution 8-).
Comment 4 Lucas Gass 2023-04-28 20:21:42 UTC

*** This bug has been marked as a duplicate of bug 33637 ***