While testing Bug 33582 I noticed that Batch patron modification seems to be broken: To recreate: 1. Get some valid cardnumbers and borrowernumbers 2. Go to Tools > Batch patron modification 3. Try entering either cardnumbers or borrowernumbers. Even with valid cardnumbers or borrowernumbers I get: No patron card numbers or borrowernumbers given.
Created attachment 150409 [details] [review] Bug 33638: Fix if statement in modborrowers.tt To test: 1. Get some valid cardnumbers and borrowernumbers 2. Go to Tools > Batch patron modification 3. Try entering either cardnumbers or borrowernumbers. 4. Apply patch 5. Try again, now it should work. 6. Make sure it works for both cardnumbers and borrowernumbers.
Created attachment 150410 [details] [review] Bug 33638: Fix if statement in modborrowers.tt To test: 1. Get some valid cardnumbers and borrowernumbers 2. Go to Tools > Batch patron modification 3. Try entering either cardnumbers or borrowernumbers. 4. Apply patch 5. Try again, now it should work. 6. Make sure it works for both cardnumbers and borrowernumbers. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
This looks like a duplicate of bug 33637 - I'll leave it to the patch authors to decide which is the 'best' solution 8-).
*** This bug has been marked as a duplicate of bug 33637 ***