Bug 33637 - Batch patron modification broken
Summary: Batch patron modification broken
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
: 33638 (view as bug list)
Depends on: 33324
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-28 15:56 UTC by Nick Clemens
Modified: 2023-06-15 14:49 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33637: Update tab ids for batch modification form (1.79 KB, patch)
2023-04-28 15:58 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 33637: Update tab ids for batch modification form (1.84 KB, patch)
2023-04-28 19:07 UTC, David Nind
Details | Diff | Splinter Review
Bug 33637: Update tab ids for batch modification form (1.89 KB, patch)
2023-04-28 22:28 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2023-04-28 15:56:51 UTC
When attempting to batch modify patrons, the inputs are always cleared because the js was not updated then the ids were changed

To recreate:
1 - Browse to tools -> Batch patron modification
2 - Enter cardnumbers and submit
3 - No patrons
4 - Enter borrowernumbers and submit
5 - No patrons
Comment 1 Nick Clemens 2023-04-28 15:58:31 UTC
Created attachment 150394 [details] [review]
Bug 33637: Update tab ids for batch modification form

This patch adjusts the ids in the submit function

To test:
1 - Browse to tools -> Batch patron modification
2 - Enter cardnumbers and submit
3 - No patrons
4 - Enter borrowernumbers and submit
5 - No patrons
6 - Apply patch
7 - Repeat
8 - Success, patrons are listed
Comment 2 David Nind 2023-04-28 19:07:16 UTC
Created attachment 150418 [details] [review]
Bug 33637: Update tab ids for batch modification form

This patch adjusts the ids in the submit function

To test:
1 - Browse to tools -> Batch patron modification
2 - Enter cardnumbers and submit
3 - No patrons
4 - Enter borrowernumbers and submit
5 - No patrons
6 - Apply patch
7 - Repeat
8 - Success, patrons are listed

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-04-28 19:11:10 UTC
This looks like a duplicate of bug 33638 - I'll leave it to the patch authors to decide which is the 'best' solution 8-).
Comment 4 Lucas Gass 2023-04-28 20:21:17 UTC
Kidclamp's is better. :)
Comment 5 Lucas Gass 2023-04-28 20:21:42 UTC
*** Bug 33638 has been marked as a duplicate of this bug. ***
Comment 6 Lucas Gass 2023-04-28 22:28:29 UTC
Trivial fix, changes make perfect sense, QA script is happy.
Comment 7 Lucas Gass 2023-04-28 22:28:58 UTC
Created attachment 150421 [details] [review]
Bug 33637: Update tab ids for batch modification form

This patch adjusts the ids in the submit function

To test:
1 - Browse to tools -> Batch patron modification
2 - Enter cardnumbers and submit
3 - No patrons
4 - Enter borrowernumbers and submit
5 - No patrons
6 - Apply patch
7 - Repeat
8 - Success, patrons are listed

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 8 Tomás Cohen Arazi 2023-05-05 18:43:22 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Martin Renvoize 2023-05-12 15:36:35 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 10 Lucas Gass 2023-06-15 14:49:05 UTC
Not needed in 22.05.x