Bug 33638

Summary: Batch patron modification is broken
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: PatronsAssignee: Lucas Gass (lukeg) <lucas>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: barbara.johnson, david, gmcharlt, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 33638: Fix if statement in modborrowers.tt
Bug 33638: Fix if statement in modborrowers.tt

Description Lucas Gass (lukeg) 2023-04-28 17:56:37 UTC
While testing Bug 33582 I noticed that Batch patron modification seems to be broken:

To recreate:
1. Get some valid cardnumbers and borrowernumbers 
2. Go to Tools > Batch patron modification
3. Try entering either cardnumbers or borrowernumbers. 

Even with valid cardnumbers or borrowernumbers I get:


No patron card numbers or borrowernumbers given.
Comment 1 Lucas Gass (lukeg) 2023-04-28 18:18:04 UTC
Created attachment 150409 [details] [review]
Bug 33638: Fix if statement in modborrowers.tt

To test:

1. Get some valid cardnumbers and borrowernumbers
2. Go to Tools > Batch patron modification
3. Try entering either cardnumbers or borrowernumbers.
4. Apply patch
5. Try again, now it should work.
6. Make sure it works for both cardnumbers and borrowernumbers.
Comment 2 PTFS Europe Sandboxes 2023-04-28 18:25:15 UTC
Created attachment 150410 [details] [review]
Bug 33638: Fix if statement in modborrowers.tt

To test:

1. Get some valid cardnumbers and borrowernumbers
2. Go to Tools > Batch patron modification
3. Try entering either cardnumbers or borrowernumbers.
4. Apply patch
5. Try again, now it should work.
6. Make sure it works for both cardnumbers and borrowernumbers.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 David Nind 2023-04-28 19:11:06 UTC
This looks like a duplicate of bug 33637 - I'll leave it to the patch authors to decide which is the 'best' solution 8-).
Comment 4 Lucas Gass (lukeg) 2023-04-28 20:21:42 UTC

*** This bug has been marked as a duplicate of bug 33637 ***