Bug 33722

Summary: Cannot see existing public lists from virtualshelves/addbybiblionumber.pl
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: CirculationAssignee: Lucas Gass (lukeg) <lucas>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: david, gmcharlt, kyle.m.hall, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 33722: Make public lists viewable for users on virtualshelves/addbybiblionumber.pl
Bug 33722: Make public lists viewable for users on virtualshelves/addbybiblionumber.pl

Description Lucas Gass (lukeg) 2023-05-11 23:16:42 UTC
To recreate:

1. Have two users with staff access and lists permissions. ( User A and User B)
2. Create some public lists with User A. Make some that are for staff only and some for everyone.
3. Make sure you create at least 10 different public lists.
4. Log in to the staff interface as user B and search the catalog. 
5. Select a few titles and in the toolbar click 'Add to list'.
6. Here you should properly see your lists and any public lists which you can edit.
7. If you have more than 10 lists you won't see them all in this dropdown.
8. At the bottom of the dropdown you should see 'More lists', click it.
9. Notice here you cannot select any of the existing public lists which User B should be able to edit.
Comment 1 Lucas Gass (lukeg) 2023-05-11 23:20:58 UTC
Created attachment 151107 [details] [review]
Bug 33722: Make public lists viewable for users on virtualshelves/addbybiblionumber.pl

To test:
1. Have two users with staff access and lists permissions. ( User A and User B)
2. Create some public lists with User A. Make some that are for staff only and some for everyone.
3. Make sure you create at least 10 different public lists.
4. Log in to the staff interface as user B and search the catalog.
5. Select a few titles and in the toolbar click 'Add to list'.
6. Here you should properly see your lists and any public lists which you can edit.
7. If you have more than 10 lists you won't see them all in this dropdown.
8. At the bottom of the dropdown you should see 'More lists', click it.
9. Notice here you cannot select any of the existing public lists which User B should be able to edit.
10. APPLY PATCH
11. Repeate steps 5 - 8. Now you should be able to edit public lists.
12. Create some private lists with User A and make sure User B cannot see them.
13. PLay with some new lists for User A and change 'Allow changes to contents from' and make sure User B can see the ones they should.
Comment 2 David Nind 2023-05-16 21:39:44 UTC
Created attachment 151328 [details] [review]
Bug 33722: Make public lists viewable for users on virtualshelves/addbybiblionumber.pl

To test:
1. Have two users with staff access and lists permissions. ( User A and User B)
2. Create some public lists with User A. Make some that are for staff only and some for everyone.
3. Make sure you create at least 10 different public lists.
4. Log in to the staff interface as user B and search the catalog.
5. Select a few titles and in the toolbar click 'Add to list'.
6. Here you should properly see your lists and any public lists which you can edit.
7. If you have more than 10 lists you won't see them all in this dropdown.
8. At the bottom of the dropdown you should see 'More lists', click it.
9. Notice here you cannot select any of the existing public lists which User B should be able to edit.
10. APPLY PATCH
11. Repeate steps 5 - 8. Now you should be able to edit public lists.
12. Create some private lists with User A and make sure User B cannot see them.
13. PLay with some new lists for User A and change 'Allow changes to contents from' and make sure User B can see the ones they should.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-05-16 21:45:01 UTC
The only thing I noticed was that you can choose to make a list Private and choose Nobody for allow changes to content.

You then lose access to the list, and even a super librarian can't see it.

This is also the case in master, so I think this is a separate bug.
Comment 4 Lucas Gass (lukeg) 2023-05-16 22:21:45 UTC
(In reply to David Nind from comment #3)
> The only thing I noticed was that you can choose to make a list Private and
> choose Nobody for allow changes to content.
> 
> You then lose access to the list, and even a super librarian can't see it.
> 
> This is also the case in master, so I think this is a separate bug.

I fail to see the point of the nobody option, for either public or private lists.
Comment 5 Marcel de Rooy 2023-05-17 11:37:03 UTC Comment hidden (obsolete)
Comment 6 Marcel de Rooy 2023-05-17 11:57:17 UTC Comment hidden (obsolete)
Comment 7 Marcel de Rooy 2023-05-17 12:02:40 UTC Comment hidden (obsolete)
Comment 8 Marcel de Rooy 2023-05-17 12:10:02 UTC Comment hidden (obsolete)
Comment 9 Marcel de Rooy 2023-05-17 12:34:30 UTC
(In reply to David Nind from comment #3)
> The only thing I noticed was that you can choose to make a list Private and
> choose Nobody for allow changes to content.
> 
> You then lose access to the list, and even a super librarian can't see it.
> 
> This is also the case in master, so I think this is a separate bug.

I thought that I saw it too. But cannot reproduce anymore now somehow. Could you give the exact steps to reproduce?
Comment 10 Marcel de Rooy 2023-05-17 12:57:56 UTC
-                [% IF private_shelves_shared_with_me.count %]
-                    <optgroup label="Private lists shared with me">
-                        [% FOREACH private_shelf IN private_shelves_shared_with_me %]
-                            <option value="[% private_shelf.shelfnumber | html %]">[% private_shelf.shelfname | html %]</option>
-                        [% END %]
-                    </optgroup>
-                [% END %]

We loose the separate display of shared lists. We still have in OPAC.
I think we should keep that distinction.
Comment 11 David Nind 2023-05-18 19:17:07 UTC
(In reply to Marcel de Rooy from comment #9)
> (In reply to David Nind from comment #3)
> > The only thing I noticed was that you can choose to make a list Private and
> > choose Nobody for allow changes to content.
> > 
> > You then lose access to the list, and even a super librarian can't see it.
> > 
> > This is also the case in master, so I think this is a separate bug.
> 
> I thought that I saw it too. But cannot reproduce anymore now somehow. Could
> you give the exact steps to reproduce?

I can't reproduce it on master now either - maybe I was mixing up my different browser windows with different staff users.

Apologies for the noise...
Comment 12 Lucas Gass (lukeg) 2023-06-06 16:50:53 UTC
(In reply to Marcel de Rooy from comment #10)
> -                [% IF private_shelves_shared_with_me.count %]
> -                    <optgroup label="Private lists shared with me">
> -                        [% FOREACH private_shelf IN
> private_shelves_shared_with_me %]
> -                            <option value="[% private_shelf.shelfnumber |
> html %]">[% private_shelf.shelfname | html %]</option>
> -                        [% END %]
> -                    </optgroup>
> -                [% END %]
> 
> We loose the separate display of shared lists. We still have in OPAC.
> I think we should keep that distinction.

Pardon my ignorance here. I don't understand how a private list can be shared with someone else.
Comment 13 Katrin Fischer 2023-06-07 06:44:52 UTC
(In reply to Lucas Gass from comment #12)
> (In reply to Marcel de Rooy from comment #10)
> > -                [% IF private_shelves_shared_with_me.count %]
> > -                    <optgroup label="Private lists shared with me">
> > -                        [% FOREACH private_shelf IN
> > private_shelves_shared_with_me %]
> > -                            <option value="[% private_shelf.shelfnumber |
> > html %]">[% private_shelf.shelfname | html %]</option>
> > -                        [% END %]
> > -                    </optgroup>
> > -                [% END %]
> > 
> > We loose the separate display of shared lists. We still have in OPAC.
> > I think we should keep that distinction.
> 
> Pardon my ignorance here. I don't understand how a private list can be
> shared with someone else.

There is a feature to share lists with each other, so you can edit them together even. It's only in the OPAC and requires  OpacAllowSharingPrivateLists.
Comment 14 Lucas Gass (lukeg) 2024-01-04 21:05:30 UTC

*** This bug has been marked as a duplicate of bug 35547 ***