When adding an item to a list from catalogue/detail.pl, we can see the latest 10 public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does. To reproduce: 1) Create 11 "staff only" lists as staff member A 2) Log in as staff member B 3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here 4) In the pulldown, choose the "More lists" option 5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list"
Created attachment 159743 [details] [review] Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up When adding an item to a list from catalogue/detail.pl, we can see the latest 10 public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does. Test plan: 1) Create 11 "staff only" lists as staff member A 2) Log in as staff member B 3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here 4) In the pulldown, choose the "More lists" option 5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list" 6) Apply this patch 7) Restart all the things! 8) Click the "More lists" option again 9) Those lists should now be in the pulldown!
Created attachment 159836 [details] [review] Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up When adding an item to a list from catalogue/detail.pl, we can see the latest 10 public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does. Test plan: 1) Create 11 "staff only" lists as staff member A 2) Log in as staff member B 3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here 4) In the pulldown, choose the "More lists" option 5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list" 6) Apply this patch 7) Restart all the things! 8) Click the "More lists" option again 9) Those lists should now be in the pulldown! Signed-off-by: sabrina <kiehl@mpis.mpg.de>
Followed all steps of the test plan and all lists are displayed after applying the patch.
Created attachment 159885 [details] [review] Bug 35547: When using "Add to a list" dialog ( addbybiblionumber.pl ) list that are "staff only" do not show up When adding an item to a list from catalogue/detail.pl, we can see the latest 10 public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does. Test plan: 1) Create 11 "staff only" lists as staff member A 2) Log in as staff member B 3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here 4) In the pulldown, choose the "More lists" option 5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list" 6) Apply this patch 7) Restart all the things! 8) Click the "More lists" option again 9) Those lists should now be in the pulldown! Signed-off-by: sabrina <kiehl@mpis.mpg.de> Signed-off-by: Mikko Liimatainen <mikko.liimatainen@turku.fi>
Created attachment 160224 [details] [review] Bug 35547: Show public "staff only" lists in addbybiblionumber.pl When adding an item to a list from catalogue/detail.pl, we can see the latest 10 public lists. If all those lists are set as "staff only" for "Allow changes to contents from" they will not show up in the addbybiblionumber.pl popup. This is because the query in the popup does not look for "staff only" lists while the "Add to list" button does. Test plan: 1) Create 11 "staff only" lists as staff member A 2) Log in as staff member B 3) Find a record, click the "Add to list" button, note you can see lists 2 through 11 here 4) In the pulldown, choose the "More lists" option 5) Note those lists are not visible in the "Choose list" pulldown under "Select an existing list" 6) Apply this patch 7) Restart all the things! 8) Click the "More lists" option again 9) Those lists should now be in the pulldown! Signed-off-by: sabrina <kiehl@mpis.mpg.de> Signed-off-by: Mikko Liimatainen <mikko.liimatainen@turku.fi> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.02
*** Bug 33722 has been marked as a duplicate of this bug. ***
Backported to 23.05.x for upcoming 23.05.08