Summary: | Vendor details - improve consistency of edit forms and display | ||
---|---|---|---|
Product: | Koha | Reporter: | David Nind <david> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, matt.blenkinsop, oleonard |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes display errors and improves the consistency of the vendor page and edit forms in acquisitions. Includes adding colons to field labels when adding an interface, making field labels all bold, and addressing some accessibility issues.
|
Version(s) released in: |
23.11.00,23.05.02
|
Bug Depends on: | 33104 | ||
Bug Blocks: | 35272 | ||
Attachments: |
Bug 33798: Add colons after the labels on the edit form
Bug 33798: Improve consistency of the vendor display view Bug 33798: Add colons after the labels on the edit form Bug 33798: Improve consistency of the vendor display view Bug 33798: Improve consistency of the vendor display view |
Description
David Nind
2023-05-22 20:34:21 UTC
Created attachment 151893 [details] [review] Bug 33798: Add colons after the labels on the edit form Created attachment 151894 [details] [review] Bug 33798: Improve consistency of the vendor display view It was not consistent: indentation, bold, etc. This patch is suggesting a new style using .page-section and .rows Is it what we want? Owen, can I get your opinion on the second patch please? (In reply to Jonathan Druart from comment #3) > Owen, can I get your opinion on the second patch please? Looks like a good improvement to me! Created attachment 152069 [details] [review] Bug 33798: Add colons after the labels on the edit form Signed-off-by: David Nind <david@davidnind.com> Created attachment 152070 [details] [review] Bug 33798: Improve consistency of the vendor display view It was not consistent: indentation, bold, etc. This patch is suggesting a new style using .page-section and .rows Is it what we want? Signed-off-by: David Nind <david@davidnind.com> Thanks Jonathan! Created attachment 152191 [details] [review] Bug 33798: Improve consistency of the vendor display view It was not consistent: indentation, bold, etc. This patch is suggesting a new style using .page-section and .rows Is it what we want? Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Appears to be dependent on 33104 which has not been backported to 22.11.x - not backporting on this basis |