Bug 33798 - Vendor details - improve consistency of edit forms and display
Summary: Vendor details - improve consistency of edit forms and display
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on: 33104
Blocks: 35272
  Show dependency tree / graph
 
Reported: 2023-05-22 20:34 UTC by David Nind
Modified: 2024-07-04 20:38 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes display errors and improves the consistency of the vendor page and edit forms in acquisitions. Includes adding colons to field labels when adding an interface, making field labels all bold, and addressing some accessibility issues.
Version(s) released in:
23.11.00,23.05.02
Circulation function:

Attachments
Bug 33798: Add colons after the labels on the edit form (2.31 KB, patch)
2023-06-01 07:09 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 33798: Improve consistency of the vendor display view (7.43 KB, patch)
2023-06-01 07:09 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 33798: Add colons after the labels on the edit form (2.35 KB, patch)
2023-06-06 20:08 UTC, David Nind 		Details | Diff | Splinter Review
Bug 33798: Improve consistency of the vendor display view (7.47 KB, patch)
2023-06-06 20:08 UTC, David Nind 		Details | Diff | Splinter Review
Bug 33798: Improve consistency of the vendor display view (7.53 KB, patch)
2023-06-08 13:15 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2023-05-22 20:34:21 UTC 
For vendor details in acquisitions, there are some inconsistencies in the display of the edit forms and vendor details.

This could do with some tidy ups.

Specific items:

1. Field labels when displaying vendor details - bold and plain text: for some sections, field labels are in bold, others are just plain text (for example: 'Vendor details' labels are in plain text, for 'Ordering information' they are bold).

2. Edit form for 'Interface details' missing colons after the labels.

2. Accessibility issues: using the WAVE Evaluation Tool browser extension (https://wave.webaim.org/), it shows lots of errors and warnings, such as missing or multiple form labels, and empty buttons and links (some of which may or may not be valid).
Comment 1 Jonathan Druart 2023-06-01 07:09:50 UTC 
Created attachment 151893 [details] [review]
Bug 33798: Add colons after the labels on the edit form
Comment 2 Jonathan Druart 2023-06-01 07:09:53 UTC 
Created attachment 151894 [details] [review]
Bug 33798: Improve consistency of the vendor display view

It was not consistent: indentation, bold, etc.

This patch is suggesting a new style using .page-section and .rows

Is it what we want?
Comment 3 Jonathan Druart 2023-06-01 07:10:47 UTC 
Owen, can I get your opinion on the second patch please?
Comment 4 Owen Leonard 2023-06-01 11:27:00 UTC 
(In reply to Jonathan Druart from comment #3)
> Owen, can I get your opinion on the second patch please?

Looks like a good improvement to me!
Comment 5 David Nind 2023-06-06 20:08:09 UTC 
Created attachment 152069 [details] [review]
Bug 33798: Add colons after the labels on the edit form

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2023-06-06 20:08:12 UTC 
Created attachment 152070 [details] [review]
Bug 33798: Improve consistency of the vendor display view

It was not consistent: indentation, bold, etc.

This patch is suggesting a new style using .page-section and .rows

Is it what we want?

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2023-06-06 20:13:47 UTC 
Thanks Jonathan!
Comment 8 Katrin Fischer 2023-06-08 13:15:06 UTC 
Created attachment 152191 [details] [review]
Bug 33798: Improve consistency of the vendor display view

It was not consistent: indentation, bold, etc.

This patch is suggesting a new style using .page-section and .rows

Is it what we want?

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Tomás Cohen Arazi (tcohen) 2023-06-09 11:42:49 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 10 Martin Renvoize (ashimema) 2023-07-12 08:24:22 UTC 
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 11 Matt Blenkinsop 2023-07-12 09:38:44 UTC 
Appears to be dependent on 33104 which has not been backported to 22.11.x - not backporting on this basis