This is very minor. I noticed that when a vendor has contracts, the space between the contracts section and the other sections disappeared. Here is what it looked like https://koha-community.org/manual/23.05/en/html/_images/vendorpage.png And this is what I currently have: https://snipboard.io/pTKWIA.jpg Notice how there is no more grey section between the ordering information section and the contracts section. To recreate: 1. If needed, create a vendor 1.1. Go to Acquisitions > New vendor 1.2. Fill out the form, including the contacts section 1.3. Click Save 2. Create a contract 2.1. Click New > Contract 2.2. Fill out the form 2.3. Click Save --> Notice there is no space between ordering information and contracts
Created attachment 158594 [details] [review] Bug 35272: Add padding above vendor contracts section This patch makes minor updates to the CSS and markup of the vendor detail page so that the different page sections have the correct margins. To test, apply the patch and rebuild the staff interface CSS. - In Acquisitions, locate a vendor and add at least one contract if necessary. - View the vendor details page. Each section (Vendor details, Ordering information, Contracts) should have comfortable and consistent margins.
Created attachment 158600 [details] [review] Bug 35272: Add padding above vendor contracts section This patch makes minor updates to the CSS and markup of the vendor detail page so that the different page sections have the correct margins. To test, apply the patch and rebuild the staff interface CSS. - In Acquisitions, locate a vendor and add at least one contract if necessary. - View the vendor details page. Each section (Vendor details, Ordering information, Contracts) should have comfortable and consistent margins. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thanks Owen!
Created attachment 158625 [details] [review] Bug 35272: Add padding above vendor contracts section This patch makes minor updates to the CSS and markup of the vendor detail page so that the different page sections have the correct margins. To test, apply the patch and rebuild the staff interface CSS. - In Acquisitions, locate a vendor and add at least one contract if necessary. - View the vendor details page. Each section (Vendor details, Ordering information, Contracts) should have comfortable and consistent margins. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.06