Bug 33998

Summary: Installer and onboarding have incorrect Font Awesome asset links
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: martin.renvoize
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33915
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:
Bug Depends on: 32910    
Bug Blocks:    
Attachments: Bug 33998: Installer and onboarding have incorrect Font Awesome asset links
Bug 33998: Installer and onboarding have incorrect Font Awesome asset links
Bug 33998: Installer and onboarding have incorrect Font Awesome asset links

Description Owen Leonard 2023-06-13 16:15:00 UTC
Bug 32910 missed updating the installer-doc-head-close.inc file. It needs to be updated to point to the correct assets.
Comment 1 Owen Leonard 2023-06-13 16:22:16 UTC
Created attachment 152310 [details] [review]
Bug 33998: Installer and onboarding have incorrect Font Awesome asset links

This patch corrects the Font Awesome asset links in the web installer.
They were not updated during the upgrade to Font Awesome 6.

Unrelated: The patch also removes the inclusion of jQueryUI. It is not
used in the installation or onboarding process.

To test, apply the patch and run the web installer. The display of
installation steps should include square icons indicating which steps
are complete.
Comment 2 Lucas Gass (lukeg) 2023-06-13 19:58:51 UTC
Created attachment 152325 [details] [review]
Bug 33998: Installer and onboarding have incorrect Font Awesome asset links

This patch corrects the Font Awesome asset links in the web installer.
They were not updated during the upgrade to Font Awesome 6.

Unrelated: The patch also removes the inclusion of jQueryUI. It is not
used in the installation or onboarding process.

To test, apply the patch and run the web installer. The display of
installation steps should include square icons indicating which steps
are complete.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Jonathan Druart 2023-06-14 10:35:10 UTC
Created attachment 152330 [details] [review]
Bug 33998: Installer and onboarding have incorrect Font Awesome asset links

This patch corrects the Font Awesome asset links in the web installer.
They were not updated during the upgrade to Font Awesome 6.

Unrelated: The patch also removes the inclusion of jQueryUI. It is not
used in the installation or onboarding process.

To test, apply the patch and run the web installer. The display of
installation steps should include square icons indicating which steps
are complete.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-06-14 12:24:41 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize (ashimema) 2023-07-17 10:02:38 UTC
Depends on 32910 not pushed to 23.05.x