Bug 33915 - Improve translation of title tags: Installer and onboarding
Summary: Improve translation of title tags: Installer and onboarding
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2023-06-06 15:58 UTC by Owen Leonard
Modified: 2024-07-04 20:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:


Attachments
Bug 33915: Improve translation of title tags: Installer and onboarding (10.68 KB, patch)
2023-06-13 16:29 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33915: Improve translation of title tags: Installer and onboarding (10.73 KB, patch)
2023-08-29 10:29 UTC, David Nind
Details | Diff | Splinter Review
Bug 33915: Improve translation of title tags: Installer and onboarding (10.82 KB, patch)
2023-09-01 09:37 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-06 15:58:10 UTC
This patch will modify the installer and onboarding templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-06-13 16:29:02 UTC
Created attachment 152312 [details] [review]
Bug 33915: Improve translation of title tags: Installer and onboarding

This patch updates installer and onboarding templates so that title
tags can be more easily translated.

To test, apply the patch and run through the installation and
onboarding process. At each stage confirm that the page title is
correct.
Comment 2 Owen Leonard 2023-06-13 16:29:59 UTC
Note that you may observe Bug 33998 during testing.
Comment 3 David Nind 2023-08-29 10:29:34 UTC
Created attachment 154898 [details] [review]
Bug 33915: Improve translation of title tags: Installer and onboarding

This patch updates installer and onboarding templates so that title
tags can be more easily translated.

To test, apply the patch and run through the installation and
onboarding process. At each stage confirm that the page title is
correct.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-08-29 10:36:52 UTC
Testing notes using KTD - to start the web installer:

1. Access the database server[1]: mysql -uroot -ppassword -hkoha-db-1
2. Drop the koha_kohadev database: drop database koha_kohadev;
3. Create the database: create database koha_kohadev;
4. Add privileges (for a real installation this would be limited): grant all on koha_kohadev.* to koha_kohadev;
5. Restart everything (there may be some errors listed): flush_memcached and then restart_all
6. Access the web installer: go to 127.0.0.1:8081
7. Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password)
8. Continue through the installation process

Note:
[1] Database password is password (from KTD .env file)
Comment 5 Jonathan Druart 2023-09-01 09:37:17 UTC
Created attachment 155086 [details] [review]
Bug 33915: Improve translation of title tags: Installer and onboarding

This patch updates installer and onboarding templates so that title
tags can be more easily translated.

To test, apply the patch and run through the installation and
onboarding process. At each stage confirm that the page title is
correct.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-09-01 14:24:29 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-09-08 05:54:12 UTC
Not backported to 23.05.x