| Summary: | Recalls awaiting pickup doesn't show count on each tab | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
|
| Circulation function: | |||
| Bug Depends on: | 34012 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 34013: Recalls awaiting pickup doesn't show count on each tab
Bug 34013: Recalls awaiting pickup doesn't show count on each tab Bug 34013: Recalls awaiting pickup doesn't show count on each tab |
||
Created attachment 152354 [details] [review] Bug 34013: Recalls awaiting pickup doesn't show count on each tab This patch modifies recalls_waiting.pl so that it defines template variables for 'recalls waiting' and 'recalls waiting over x days' counts in the same way that waitingreserves.pl handles it. To test you must have UseRecalls enabled, and some recalls data that will allow you to see content under each tab. Go to Circulation -> Recalls awaiting pickup and confirm that both tabs show the correct count. Created attachment 152356 [details] [review] Bug 34013: Recalls awaiting pickup doesn't show count on each tab This patch modifies recalls_waiting.pl so that it defines template variables for 'recalls waiting' and 'recalls waiting over x days' counts in the same way that waitingreserves.pl handles it. To test you must have UseRecalls enabled, and some recalls data that will allow you to see content under each tab. Go to Circulation -> Recalls awaiting pickup and confirm that both tabs show the correct count. Signed-off-by: Sam Lau <samalau@gmail.com> *** Bug 34104 has been marked as a duplicate of this bug. *** Created attachment 152597 [details] [review] Bug 34013: Recalls awaiting pickup doesn't show count on each tab This patch modifies recalls_waiting.pl so that it defines template variables for 'recalls waiting' and 'recalls waiting over x days' counts in the same way that waitingreserves.pl handles it. To test you must have UseRecalls enabled, and some recalls data that will allow you to see content under each tab. Go to Circulation -> Recalls awaiting pickup and confirm that both tabs show the correct count. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to 22.11.x for next release |
The recalls awaiting pickup page is supposed to show a count on each tab, e.g. Recalls waiting: 10 Recalls waiting over 7 days: 14 The template tries to do it this way: Recalls waiting: [% recalls.count | html %] But it doesn't work.