Bug 34012 - Use template wrapper for tabs: Recalls awaiting pickup
Summary: Use template wrapper for tabs: Recalls awaiting pickup
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 34010
Blocks: 32571 34013
  Show dependency treegraph
 
Reported: 2023-06-14 17:03 UTC by Owen Leonard
Modified: 2023-12-28 20:47 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup (19.50 KB, patch)
2023-06-14 17:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup (19.60 KB, patch)
2023-06-14 18:27 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup (19.64 KB, patch)
2023-06-14 22:39 UTC, David Nind
Details | Diff | Splinter Review
Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup (19.59 KB, patch)
2023-06-14 22:44 UTC, David Nind
Details | Diff | Splinter Review
Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup (19.65 KB, patch)
2023-06-22 21:04 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-14 17:03:58 UTC
Continuing the work of Bug 32571, I would like to update the recalls awaiting pickup page in the staff client to use the new WRAPPER for tabs
Comment 1 Owen Leonard 2023-06-14 17:14:40 UTC
Created attachment 152351 [details] [review]
Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup

This patch updates the recalls awaiting pickup template so that it uses
the new WRAPPER directive to build tabbed navigation.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test you must have UseRecalls enabled. Apply the patch and go to
Circulation -> Recalls awaiting pickup.

Both the "Recalls waiting" and "Recalls waiting over X days" tabs should
look correct and work correctly.
Comment 2 Sam Lau 2023-06-14 18:27:24 UTC
Created attachment 152358 [details] [review]
Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup

This patch updates the recalls awaiting pickup template so that it uses
the new WRAPPER directive to build tabbed navigation.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test you must have UseRecalls enabled. Apply the patch and go to
Circulation -> Recalls awaiting pickup.

Both the "Recalls waiting" and "Recalls waiting over X days" tabs should
look correct and work correctly.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 David Nind 2023-06-14 22:39:34 UTC Comment hidden (obsolete)
Comment 4 David Nind 2023-06-14 22:43:12 UTC
The only thing I noticed was that the buttons (such as 'Revert waiting status' and 'Expire recall') were previously orange, but are now standard buttons with a white background.

Also, I didn't refresh the bug page, and note that was already signed off. I also managed to add a bugzilla link, which I'll fix up.
Comment 5 David Nind 2023-06-14 22:44:20 UTC
Created attachment 152362 [details] [review]
Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup

This patch updates the recalls awaiting pickup template so that it uses
the new WRAPPER directive to build tabbed navigation.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test you must have UseRecalls enabled. Apply the patch and go to
Circulation -> Recalls awaiting pickup.

Both the "Recalls waiting" and "Recalls waiting over X days" tabs should
look correct and work correctly.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Katrin Fischer 2023-06-22 21:04:58 UTC
Created attachment 152596 [details] [review]
Bug 34012: Use template wrapper for tabs: Recalls awaiting pickup

This patch updates the recalls awaiting pickup template so that it uses
the new WRAPPER directive to build tabbed navigation.

Note: this patch includes indentation changes, so check the diff
accordingly.

To test you must have UseRecalls enabled. Apply the patch and go to
Circulation -> Recalls awaiting pickup.

Both the "Recalls waiting" and "Recalls waiting over X days" tabs should
look correct and work correctly.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2023-06-23 13:02:01 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Martin Renvoize 2023-07-17 14:03:10 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 9 Pedro Amorim 2023-07-18 11:54:58 UTC
Nice work everyone!

Pushed to 22.11.x for next release