Bug 34013 - Recalls awaiting pickup doesn't show count on each tab
Summary: Recalls awaiting pickup doesn't show count on each tab
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
: 34104 (view as bug list)
Depends on: 34012
Blocks:
  Show dependency tree / graph
 
Reported: 2023-06-14 17:21 UTC by Owen Leonard
Modified: 2023-12-28 20:46 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08
Circulation function:

Attachments
Bug 34013: Recalls awaiting pickup doesn't show count on each tab (2.46 KB, patch)
2023-06-14 17:29 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 34013: Recalls awaiting pickup doesn't show count on each tab (2.50 KB, patch)
2023-06-14 18:18 UTC, Sam Lau 		Details | Diff | Splinter Review
Bug 34013: Recalls awaiting pickup doesn't show count on each tab (2.56 KB, patch)
2023-06-22 21:08 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-14 17:21:41 UTC 
The recalls awaiting pickup page is supposed to show a count on each tab, e.g.

    Recalls waiting: 10
    Recalls waiting over 7 days: 14

The template tries to do it this way:

    Recalls waiting: [% recalls.count | html %]

But it doesn't work.
Comment 1 Owen Leonard 2023-06-14 17:29:22 UTC 
Created attachment 152354 [details] [review]
Bug 34013: Recalls awaiting pickup doesn't show count on each tab

This patch modifies recalls_waiting.pl so that it defines template
variables for 'recalls waiting' and 'recalls waiting over x days'
counts in the same way that waitingreserves.pl handles it.

To test you must have UseRecalls enabled, and some recalls data that
will allow you to see content under each tab.

Go to Circulation -> Recalls awaiting pickup and confirm that both tabs
show the correct count.
Comment 2 Sam Lau 2023-06-14 18:18:03 UTC 
Created attachment 152356 [details] [review]
Bug 34013: Recalls awaiting pickup doesn't show count on each tab

This patch modifies recalls_waiting.pl so that it defines template
variables for 'recalls waiting' and 'recalls waiting over x days'
counts in the same way that waitingreserves.pl handles it.

To test you must have UseRecalls enabled, and some recalls data that
will allow you to see content under each tab.

Go to Circulation -> Recalls awaiting pickup and confirm that both tabs
show the correct count.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Katrin Fischer 2023-06-22 21:04:08 UTC 
*** Bug 34104 has been marked as a duplicate of this bug. ***
Comment 4 Katrin Fischer 2023-06-22 21:08:39 UTC 
Created attachment 152597 [details] [review]
Bug 34013: Recalls awaiting pickup doesn't show count on each tab

This patch modifies recalls_waiting.pl so that it defines template
variables for 'recalls waiting' and 'recalls waiting over x days'
counts in the same way that waitingreserves.pl handles it.

To test you must have UseRecalls enabled, and some recalls data that
will allow you to see content under each tab.

Go to Circulation -> Recalls awaiting pickup and confirm that both tabs
show the correct count.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-06-23 13:02:05 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Martin Renvoize (ashimema) 2023-07-17 14:03:13 UTC 
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 7 Pedro Amorim 2023-07-18 11:55:02 UTC 
Nice work everyone!

Pushed to 22.11.x for next release