| Summary: | authorised-values API client file is missing -api-client suffix | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.03,22.11.09
|
|
| Circulation function: | |||
| Bug Depends on: | 32983 | ||
| Bug Blocks: | 34055 | ||
| Attachments: |
Bug 34056: Add -api-client suffit to authorised-values API client
Bug 34056: Add -api-client suffit to authorised-values API client Bug 34056: Add -api-client suffit to authorised-values API client |
||
|
Description
Jonathan Druart
2023-06-19 08:13:33 UTC
Created attachment 152469 [details] [review] Bug 34056: Add -api-client suffit to authorised-values API client In koha-tmpl/intranet-tmpl/prog/js/vue/fetch all files have the -api-client suffix but authorised-values. For consistency we should add it. Test plan: Go to the ERM module and confirm that dropdown lists are correctly filled in with authorised values. You can also inspect the console and confirm that a GET query to /authorised_value_categories is done Sponsored-by: BULAC - http://www.bulac.fr/ Created attachment 153531 [details] [review] Bug 34056: Add -api-client suffit to authorised-values API client In koha-tmpl/intranet-tmpl/prog/js/vue/fetch all files have the -api-client suffix but authorised-values. For consistency we should add it. Test plan: Go to the ERM module and confirm that dropdown lists are correctly filled in with authorised values. You can also inspect the console and confirm that a GET query to /authorised_value_categories is done Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 154072 [details] [review] Bug 34056: Add -api-client suffit to authorised-values API client In koha-tmpl/intranet-tmpl/prog/js/vue/fetch all files have the -api-client suffix but authorised-values. For consistency we should add it. Test plan: Go to the ERM module and confirm that dropdown lists are correctly filled in with authorised values. You can also inspect the console and confirm that a GET query to /authorised_value_categories is done Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.03 Nice work everyone! Pushed to 22.11.x for next release |