Bug 32981 let us retrieve the authorised values from a REST API route, instead of injecting them from the template. Let us that for the ERM module!
Created attachment 146732 [details] [review] Bug 32983: ERM - Retrieve AVs from an endpoint Bug 32981 let us retrieve the authorised values from a REST API route, instead of injecting them from the template. Let us that for the ERM module! Test plan: You will notice a "Loading" screen when refreshing the ERM module Then you should not notice any other UI changes. Dropdown list should be populated like before this patch. Some technical notes: I am expecting this to be slower than before, but it feels better to use a REST API route to retrieve the AV Future improvement will be to lazy load the AVs, to speed up the landing page. However it needs more changes, and this gets big enough. I would like to see a follow-up that move the code from ERM/Main.vue to the authorised value store (I've failed at that), but that should certainly be done after the lazy loading is implemented anyway)
Created attachment 146733 [details] [review] Bug 32983: ERM - Retrieve AVs from an endpoint Bug 32981 let us retrieve the authorised values from a REST API route, instead of injecting them from the template. Let us that for the ERM module! Test plan: You will notice a "Loading" screen when refreshing the ERM module Then you should not notice any other UI changes. Dropdown list should be populated like before this patch. Some technical notes: I am expecting this to be slower than before, but it feels better to use a REST API route to retrieve the AV Future improvement will be to lazy load the AVs, to speed up the landing page. However it needs more changes, and this gets big enough. I would like to see a follow-up that move the code from ERM/Main.vue to the authorised value store (I've failed at that), but that should certainly be done after the lazy loading is implemented anyway)
Created attachment 147050 [details] [review] Bug 32983: ERM - Retrieve AVs from an endpoint Bug 32981 let us retrieve the authorised values from a REST API route, instead of injecting them from the template. Let us that for the ERM module! Test plan: You will notice a "Loading" screen when refreshing the ERM module Then you should not notice any other UI changes. Dropdown list should be populated like before this patch. Some technical notes: I am expecting this to be slower than before, but it feels better to use a REST API route to retrieve the AV Future improvement will be to lazy load the AVs, to speed up the landing page. However it needs more changes, and this gets big enough. I would like to see a follow-up that move the code from ERM/Main.vue to the authorised value store (I've failed at that), but that should certainly be done after the lazy loading is implemented anyway)
Created attachment 147081 [details] [review] Bug 32983: ERM - Retrieve AVs from an endpoint Bug 32981 let us retrieve the authorised values from a REST API route, instead of injecting them from the template. Let us that for the ERM module! Test plan: You will notice a "Loading" screen when refreshing the ERM module Then you should not notice any other UI changes. Dropdown list should be populated like before this patch. Some technical notes: I am expecting this to be slower than before, but it feels better to use a REST API route to retrieve the AV Future improvement will be to lazy load the AVs, to speed up the landing page. However it needs more changes, and this gets big enough. I would like to see a follow-up that move the code from ERM/Main.vue to the authorised value store (I've failed at that), but that should certainly be done after the lazy loading is implemented anyway) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 147228 [details] [review] Bug 32983: Use REST API route to retrieve authorised values Make one API call for all AV categories+values instead of one API call per AV category required
Created attachment 147283 [details] [review] Bug 32983: Use REST API route to retrieve authorised values Make one API call for all AV categories+values instead of one API call per AV category required Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 147348 [details] [review] Bug 32983: ERM - Retrieve AVs from an endpoint Bug 32981 let us retrieve the authorised values from a REST API route, instead of injecting them from the template. Let us that for the ERM module! Test plan: You will notice a "Loading" screen when refreshing the ERM module Then you should not notice any other UI changes. Dropdown list should be populated like before this patch. Some technical notes: I am expecting this to be slower than before, but it feels better to use a REST API route to retrieve the AV Future improvement will be to lazy load the AVs, to speed up the landing page. However it needs more changes, and this gets big enough. I would like to see a follow-up that move the code from ERM/Main.vue to the authorised value store (I've failed at that), but that should certainly be done after the lazy loading is implemented anyway) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 147349 [details] [review] Bug 32983: Use REST API route to retrieve authorised values Make one API call for all AV categories+values instead of one API call per AV category required Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 147585 [details] [review] Bug 32983: Use REST API route to retrieve authorised values Make one API call for all AV categories+values instead of one API call per AV category required Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Run prettier on Main.vue for the second patch.
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
This breaks the complete API, as far as I can see: [2023/03/06 09:13:28] [ERROR] Warning: Could not load REST API spec bundle: /parameters/authorised_value_id_pp/in: /oneOf/0 Not in enum list: body./parameters/authorised_value_id_pp/in: /oneOf/1/oneOf/0 Not in enum list: header./parameters/authorised_value_id_pp/in: /oneOf/1/oneOf/1 Not in enum list: formData./parameters/authorised_value_id_pp/in: /oneOf/1/oneOf/2 Not in enum list: query./parameters/authorised_value_id_pp/required: /oneOf/1/oneOf/3 Missing property./parameters/authorised_value_id_pp/schema: /oneOf/0 Missing property./parameters/authorised_value_id_pp/type: /oneOf/1 Missing property. at /usr/share/perl5/Mojolicious/Plugin/OpenAPI.pm line 27.
Not sure what happens but 33145 seems to resolve issues
Created attachment 147959 [details] [review] Bug 32983: Fix dropdown list when search for EBSCO's packages
Enhancement will not be backported to 22.05.x
Follow-up pushed to master.
Follow-up pushed to stable